[GitHub] [maven-site] MartinKanters commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

[GitBox <gi...@apache.org>]

MartinKanters commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r624514244



##########
File path: content/apt/guides/mini/guide-multiple-modules.apt
##########
@@ -59,25 +75,117 @@ Guide to Working with Multiple Modules
 
   Note that only "instantiated" references are used - <<<dependencyManagement>>> and <<<pluginManagement>>> elements do not cause a change to the reactor sort order.
 
-** Command Line Options
+** Selecting Modules

Review comment:
       Well yeah, that's a hard one, there are definitely a couple of things changed in this section, but not everything is new. For example, including/excluding projects with `-pl` was always possible, but optional project (`?` prefix) selection was added. 
   We tried to come up with some somewhat more 'advanced' changes between 3 and 4 in the table at the bottom of the page. I think it will become too chaotic to link every new thing to a "Maven 4 tip". Some advanced (breaking) changes are listed in the table below.
   
   We have briefly thought of keeping the [current guide](https://maven.apache.org/guides/mini/guide-multiple-modules.html) on a separate page. And linking to and from that from this new page... a.k.a. "These docs contain Maven 4 features, looking for Maven 3 docs? -> <insert link>" and vice versa. Do you think that would be valuable? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org