You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Nathan Hamblen (JIRA)" <ji...@apache.org> on 2007/11/20 03:18:43 UTC
[jira] Created: (WICKET-1171) Tolerate malformed If-Modified-Since
header
Tolerate malformed If-Modified-Since header
-------------------------------------------
Key: WICKET-1171
URL: https://issues.apache.org/jira/browse/WICKET-1171
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-rc1
Reporter: Nathan Hamblen
Priority: Minor
Some kind of RSS aggregator is hitting an rc1 site of mine regularly with dates that don't follow the HTTP spec. Correct to the servlet spec, Jetty throws an exception in this instance which causes Wicket to abort processing the request and log an error. I think it would be better to log the exception as a warning and proceed as if the header had not been present.
Example exception:
ERROR btpool0-703 org.mortbay.log - /resources/com.typeturner.Typeturner/eat-rss
java.lang.IllegalArgumentException: Cannot convert date: 1194673976
at org.mortbay.jetty.HttpFields.getDateField(HttpFields.java:827)
at org.mortbay.jetty.Request.getDateHeader(Request.java:460)
at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:197)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1171) Tolerate malformed If-Modified-Since
header
Posted by "Nathan Hamblen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Hamblen updated WICKET-1171:
-----------------------------------
Attachment: date-header.diff
Patch to tolerate malformed dates in header
> Tolerate malformed If-Modified-Since header
> -------------------------------------------
>
> Key: WICKET-1171
> URL: https://issues.apache.org/jira/browse/WICKET-1171
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Reporter: Nathan Hamblen
> Priority: Minor
> Attachments: date-header.diff
>
>
> Some kind of RSS aggregator is hitting an rc1 site of mine regularly with dates that don't follow the HTTP spec. Correct to the servlet spec, Jetty throws an exception in this instance which causes Wicket to abort processing the request and log an error. I think it would be better to log the exception as a warning and proceed as if the header had not been present.
> Example exception:
> ERROR btpool0-703 org.mortbay.log - /resources/com.typeturner.Typeturner/eat-rss
> java.lang.IllegalArgumentException: Cannot convert date: 1194673976
> at org.mortbay.jetty.HttpFields.getDateField(HttpFields.java:827)
> at org.mortbay.jetty.Request.getDateHeader(Request.java:460)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:197)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1171) Tolerate malformed If-Modified-Since
header
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-1171.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-rc2
> Tolerate malformed If-Modified-Since header
> -------------------------------------------
>
> Key: WICKET-1171
> URL: https://issues.apache.org/jira/browse/WICKET-1171
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Reporter: Nathan Hamblen
> Priority: Minor
> Fix For: 1.3.0-rc2
>
> Attachments: date-header.diff
>
>
> Some kind of RSS aggregator is hitting an rc1 site of mine regularly with dates that don't follow the HTTP spec. Correct to the servlet spec, Jetty throws an exception in this instance which causes Wicket to abort processing the request and log an error. I think it would be better to log the exception as a warning and proceed as if the header had not been present.
> Example exception:
> ERROR btpool0-703 org.mortbay.log - /resources/com.typeturner.Typeturner/eat-rss
> java.lang.IllegalArgumentException: Cannot convert date: 1194673976
> at org.mortbay.jetty.HttpFields.getDateField(HttpFields.java:827)
> at org.mortbay.jetty.Request.getDateHeader(Request.java:460)
> at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:197)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.