You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/22 03:56:14 UTC

[GitHub] [rocketmq] 2259289435 removed a comment on issue #1734: [ISSUE #1727] fix RequestCallback executed multi times

2259289435 removed a comment on issue #1734: [ISSUE #1727] fix RequestCallback executed multi times
URL: https://github.com/apache/rocketmq/pull/1734#issuecomment-576996279
 
 
   修改callback有点不好
   1，callback是很早之前就开放给客户端使用了，现在改为只能执行一次，对低版本升级兼容有影响
   2，重复多次只有callback异常才会发生，我建议的是迭代的时候标记key，然后执行exception的时候再去removekey，这样也解决了并发问题，对原有的callback也没有影响。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services