You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 10:57:31 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #1764: Added ssl authentation to the nats extensions
aldettinger opened a new pull request #1764:
URL: https://github.com/apache/camel-quarkus/pull/1764
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #1764: Added ssl authentation to the nats extensions
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #1764:
URL: https://github.com/apache/camel-quarkus/pull/1764#issuecomment-689521190
Ok, let's merge now then. Thanks for review guys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1764: Added ssl authentation to the nats extensions
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1764:
URL: https://github.com/apache/camel-quarkus/pull/1764#issuecomment-689492217
> Better merge it after 1.1.0 release.
Why? I do not see anything risky here (maybe I am missing something?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #1764: Added ssl authentation to the nats extensions
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #1764:
URL: https://github.com/apache/camel-quarkus/pull/1764#issuecomment-689490138
Better merge it after 1.1.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #1764: Added ssl authentation to the nats extensions
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #1764:
URL: https://github.com/apache/camel-quarkus/pull/1764#discussion_r485523019
##########
File path: integration-tests/nats/src/test/java/org/apache/camel/quarkus/component/nats/it/NatsTestResource.java
##########
@@ -63,6 +65,20 @@
Integer noAuthPort = noAuthContainer.getMappedPort(NATS_SERVER_PORT);
String noAuthBrokerUrl = String.format("%s:%s", noAuthIp, noAuthPort);
+ // Start the container needed for the TLS authentication test
+ tlsAuthContainer = new GenericContainer(NATS_IMAGE).withExposedPorts(NATS_SERVER_PORT)
+ .withClasspathResourceMapping("certs", "/certs", BindMode.READ_ONLY)
Review comment:
It uses `ClassLoader.getResource(...)` under the hood, so I think the test could be executed on platform too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #1764: Added ssl authentation to the nats extensions
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #1764:
URL: https://github.com/apache/camel-quarkus/pull/1764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org