You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/24 08:48:37 UTC

[GitHub] [pulsar] momo-jun opened a new pull request #14445: [Doc] ZooKeeper stats port correction since 2.8.0

momo-jun opened a new pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445


   ### Modifications
   
   As per https://github.com/apache/pulsar/issues/11467, ZooKeeper starts to use an internal Prometheus metric provider since 3.6.0.
   
   Modify the document (https://pulsar.apache.org/docs/en/2.8.0/deploy-monitoring/#zookeeper-stats) to replace the previous config `stats_server_port` with `metricsProvider.httpPort` in the `conf/zookeeper.conf' file for configuring a different stats port.
   
   Note this change will be applied to more historical doc versions since 2.8.0.
   
   
   ### Documentation
   
   - [ ] `doc` 
     
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a change in pull request #14445: [Doc] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
momo-jun commented on a change in pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445#discussion_r813828320



##########
File path: site2/docs/deploy-monitoring.md
##########
@@ -43,7 +43,7 @@ http://$LOCAL_ZK_SERVER:8000/metrics
 http://$GLOBAL_ZK_SERVER:8001/metrics
 ```
 
-The default port of local ZooKeeper is `8000` and the default port of configuration store is `8001`. You can change the default port of local ZooKeeper and configuration store by specifying system property `stats_server_port`.
+The default port of local ZooKeeper is `8000` and the default port of configuration store is `8001`. You can use a different stats port by configuring `metricsProvider.httpPort` in the `conf/zookeeper.conf` file.

Review comment:
       Thanks Yu. I've fixed that too when applying the same changes to other versions. Now this PR can be merged. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun edited a comment on pull request #14445: [Doc] [Do-not-Merge] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
momo-jun edited a comment on pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445#issuecomment-1049623676


   Hi @Technoboy-  @zymap @Anonymitaet can you please review this doc PR? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #14445: [Doc] [Do-not-Merge] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445#issuecomment-1049623676


   Hi @zymap @Anonymitaet can you please review this doc PR? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #14445: [Doc] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14445: [Doc] [Do-not-Merge] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445#issuecomment-1049623109


   @momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14445: [Doc] [Do-not-Merge] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445#issuecomment-1049623532


   @momo-jun:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14445: [Doc] [Do-not-Merge] ZooKeeper stats port correction since 2.8.0

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14445:
URL: https://github.com/apache/pulsar/pull/14445#discussion_r813708811



##########
File path: site2/docs/deploy-monitoring.md
##########
@@ -43,7 +43,7 @@ http://$LOCAL_ZK_SERVER:8000/metrics
 http://$GLOBAL_ZK_SERVER:8001/metrics
 ```
 
-The default port of local ZooKeeper is `8000` and the default port of configuration store is `8001`. You can change the default port of local ZooKeeper and configuration store by specifying system property `stats_server_port`.
+The default port of local ZooKeeper is `8000` and the default port of configuration store is `8001`. You can use a different stats port by configuring `metricsProvider.httpPort` in the `conf/zookeeper.conf` file.

Review comment:
       ```suggestion
   The default port of local ZooKeeper is `8000` and the default port of the configuration store is `8001`. You can use a different stats port by configuring `metricsProvider.httpPort` in the `conf/zookeeper.conf` file.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org