[GitHub] [geode] bschuchardt opened a new pull request #5250: GEODE-8144: setting SNI server name is not needed if endpoint verification is disabled

[GitBox <gi...@apache.org>]

bschuchardt opened a new pull request #5250:
URL: https://github.com/apache/geode/pull/5250


   I've modified the fix for GEODE-8144 to not set the SNI server name parameter
   if endpoint verification is disabled.  The parameter is only needed if endpoint
   verification is enabled.  Some performance tests that had endpoint identification
   disabled were showing degraded perf.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] bschuchardt merged pull request #5250: GEODE-8144: setting SNI server name is not needed if endpoint verification is disabled

[GitBox <gi...@apache.org>]

bschuchardt merged pull request #5250:
URL: https://github.com/apache/geode/pull/5250


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org