You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/24 14:10:23 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #110: Try to use license-eye to check license
kezhenxu94 opened a new pull request #110:
URL: https://github.com/apache/skywalking-python/pull/110
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #110: Set up license-eye to check license
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #110:
URL: https://github.com/apache/skywalking-python/pull/110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #110: Try to use license-eye to check license
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #110:
URL: https://github.com/apache/skywalking-python/pull/110#discussion_r548542093
##########
File path: .github/workflows/build.yaml
##########
@@ -37,6 +37,10 @@ jobs:
uses: actions/checkout@v2
with:
submodules: true
+ - name: Check License
+ uses: apache/skywalking-eyes@main
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Review comment:
Yes, this can be done after license-eye is released, but now just to verify it works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on a change in pull request #110: Try to use license-eye to check license
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #110:
URL: https://github.com/apache/skywalking-python/pull/110#discussion_r548541507
##########
File path: .github/workflows/build.yaml
##########
@@ -37,6 +37,10 @@ jobs:
uses: actions/checkout@v2
with:
submodules: true
+ - name: Check License
+ uses: apache/skywalking-eyes@main
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Review comment:
Should we officially merge this after the eye 0.1.0 release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org