You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/26 11:08:08 UTC
[GitHub] [cordova-android] mosabab opened a new pull request #1174: feat: upgrade gradle@6.8.3
mosabab opened a new pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Gradle version to 6.8.3
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808128415
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=h1) Report
> Merging [#1174](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=desc) (b414f01) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head b414f01 differs from pull request most recent head 999c141. Consider uploading reports for the commit 999c141 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 71.80% 71.74% -0.06%
==========================================
Files 21 21
Lines 1745 1745
==========================================
- Hits 1253 1252 -1
- Misses 492 493 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=footer). Last update [3081e5e...999c141](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808128415
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=h1) Report
> Merging [#1174](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=desc) (b414f01) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head b414f01 differs from pull request most recent head ce24143. Consider uploading reports for the commit ce24143 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1174 +/- ##
=======================================
Coverage 71.80% 71.80%
=======================================
Files 21 21
Lines 1745 1745
=======================================
Hits 1253 1253
Misses 492 492
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=footer). Last update [3081e5e...ce24143](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808128415
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=h1) Report
> Merging [#1174](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=desc) (b414f01) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head b414f01 differs from pull request most recent head a516ec8. Consider uploading reports for the commit a516ec8 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1174 +/- ##
=======================================
Coverage 71.80% 71.80%
=======================================
Files 21 21
Lines 1745 1745
=======================================
Hits 1253 1253
Misses 492 492
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=footer). Last update [3081e5e...a516ec8](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808128415
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=h1) Report
> Merging [#1174](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=desc) (999c141) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 999c141 differs from pull request most recent head ce24143. Consider uploading reports for the commit ce24143 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 71.80% 71.74% -0.06%
==========================================
Files 21 21
Lines 1745 1745
==========================================
- Hits 1253 1252 -1
- Misses 492 493 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=footer). Last update [3081e5e...ce24143](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808734167
Thank you for your contribution @mosabab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808128415
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=h1) Report
> Merging [#1174](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=desc) (b414f01) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head b414f01 differs from pull request most recent head 999c141. Consider uploading reports for the commit 999c141 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 71.80% 71.74% -0.06%
==========================================
Files 21 21
Lines 1745 1745
==========================================
- Hits 1253 1252 -1
- Misses 492 493 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=footer). Last update [3081e5e...999c141](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174#issuecomment-808128415
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=h1) Report
> Merging [#1174](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=desc) (b414f01) into [master](https://codecov.io/gh/apache/cordova-android/commit/3081e5e6e91c32e507423411196b184325baa935?el=desc) (3081e5e) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head b414f01 differs from pull request most recent head a516ec8. Consider uploading reports for the commit a516ec8 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 71.80% 71.74% -0.06%
==========================================
Files 21 21
Lines 1745 1745
==========================================
- Hits 1253 1252 -1
- Misses 492 493 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1174/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=footer). Last update [3081e5e...a516ec8](https://codecov.io/gh/apache/cordova-android/pull/1174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1174: feat: upgrade gradle@6.8.3
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1174:
URL: https://github.com/apache/cordova-android/pull/1174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org