[GitHub] [tvm] areusch commented on pull request #8014: [AOT] Name mangling in AOT

[GitBox <gi...@apache.org>]

areusch commented on pull request #8014:
URL: https://github.com/apache/tvm/pull/8014#issuecomment-865437382


   apologies, i think i missed this and it now needs a rebase or merge.
   
   i discussed this with @jroesch a bit as well, who is now working in earnest to merge #7518 in the next two weeks. following that PR, we'll arrive at a state where we can begin to think of the entire compiler as a series of IRModule passes. our discussion was that, at that point, it probably makes sense to move things like name mangling and e.g. the type signature changes proposed by @Mousius to one end of the compiler stack (i.e. at the relay level or at the end of the TIR passes). this way, the middle part of the compiler remains as generic as possible.
   
   we'd like to propose the following:
   - let us sync and merge this PR
   - we'll land #7518 on top of this in the next two weeks (e.g. aiming for before July 4 US holiday)
   - following that PR, we'll likely reorganize this and move it to the end of the TIR passes
   
   to that end, we'd like to briefly prioritize #7518 next week over AOT changes to reduce the churn and let it land, since it's a fairly invasive PR.
   
   if that's ok with you guys, i'll hand this off to @jroesch to merge while i'm ooo next few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org