You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Matthew F. Dennis (Created) (JIRA)" <ji...@apache.org> on 2011/11/18 22:48:52 UTC

[jira] [Created] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
-----------------------------------------------------------------------------------------------------------------------------------

                 Key: CASSANDRA-3508
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 1.0.1
            Reporter: Matthew F. Dennis




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3508:
--------------------------------------

          Component/s: Tools
             Priority: Minor  (was: Major)
    Affects Version/s:     (was: 1.0.1)
             Assignee: Pavel Yaskevich
    
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154329#comment-13154329 ] 

Jonathan Ellis commented on CASSANDRA-3508:
-------------------------------------------

+1
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508-v2.patch, CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154313#comment-13154313 ] 

Jonathan Ellis commented on CASSANDRA-3508:
-------------------------------------------

I'd be okay with keeping --debug around for that.
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Matthew F. Dennis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew F. Dennis updated CASSANDRA-3508:
-----------------------------------------

    Description: this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"
    
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>            Reporter: Matthew F. Dennis
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-3508:
---------------------------------------

    Attachment: CASSANDRA-3508-v2.patch

this patch keeps the --debug option and shows exceptions in the places your mentioned only when that option is set.
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508-v2.patch, CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Pavel Yaskevich (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154259#comment-13154259 ] 

Pavel Yaskevich commented on CASSANDRA-3508:
--------------------------------------------

I agree that we can remove it from the first one (describeRing) but I think we should keep stack-trace for login as it could be handy to have.
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-3508:
---------------------------------------

    Attachment: CASSANDRA-3508.patch

removes explicit --debug requirement and prints stack-traces in cases where it's necessary.
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154241#comment-13154241 ] 

Jonathan Ellis commented on CASSANDRA-3508:
-------------------------------------------

We need to be a little judicious here.  Simply printing stacktraces for *all* exceptions is not right either.  For instance, it looks to me like

{code}
             sessionState.err.println(e.getWhy());
 
-            if (sessionState.debug)
-                e.printStackTrace();
+            e.printStackTrace(sessionState.err);
{code}

{code}
-            if (sessionState.debug)
-                e.printStackTrace();
-            
             sessionState.err.println("Login failure. Did you specify 'keyspace', 'username' and 'password'?");
+            e.printStackTrace(sessionState.err);
{code}

should not be stacktraces by default.
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira