You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/03/19 20:37:13 UTC

[GitHub] eiri commented on issue #1226: Investigate how hard could it be to reintroduce etags in index's views.

eiri commented on issue #1226: Investigate  how hard could it be to reintroduce etags in index's views. 
URL: https://github.com/apache/couchdb/issues/1226#issuecomment-374365839
 
 
   A side note: I don't think chttpd family of etag functions is actually working. Make ETag generates binary [make_etag](https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd.erl#L667), but validator 
    [`etag_match/2`](https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd.erl#L674) checks it versus tokenized header value, which gives a list of strings.
   
   It's an easy fix, but I'm hesitant to introduce it as part of this work, it seems that `etag_respond/3` used in quite a few places in chttpd, so complete fix would make this PR rather messy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services