[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #16184: Add large tensor nightly tests for MKL-DNN operators

[GitBox <gi...@apache.org>]

pengzhao-intel commented on issue #16184: Add large tensor nightly tests for MKL-DNN operators
URL: https://github.com/apache/incubator-mxnet/pull/16184#issuecomment-532933688
 
 
   > Can't we reuse the already existing large tensor tests? From a front-end perspective, it shouldn't matter to the user which backend is being used, right?
   > 
   > I understand that in the backend MKLDNN only supports float32 as input for now, but how about we hide that fact and instead do some magic in the backend in the meantime? IMO, the user-code should not be backend specific and thus we should use the same tests to enforce that constraint.
   > 
   > I'd like to stay away from backend specific tests as much as possible, so I'd appreciate it if we could rather work towards improving these intermediary layers instead of adding a second set of tests.
   
   @marcoabreu  Good point! I think these codes are backend independent :)
   @wuxun-zhang you can try to remove the MKL-DNN in the file name and run it with different backends.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services