You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Harald Wellmann (JIRA)" <ji...@apache.org> on 2012/12/03 14:15:58 UTC

[jira] [Created] (TOMEE-623) Make TomEE m2e-friendly

Harald Wellmann created TOMEE-623:
-------------------------------------

             Summary: Make TomEE m2e-friendly
                 Key: TOMEE-623
                 URL: https://issues.apache.org/jira/browse/TOMEE-623
             Project: TomEE
          Issue Type: Improvement
    Affects Versions: 1.5.0
            Reporter: Harald Wellmann
             Fix For: 1.5.1


Use Case

* You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
* You want to import the TomEE/OpenEJB source tree to start hacking TomEE.

Problem

* Most subprojects have error markers caused by Maven plugins unknown to m2e.

Solution:

* Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510047#comment-13510047 ] 

Harald Wellmann commented on TOMEE-623:
---------------------------------------

No, all these settings are specific to m2e and Eclipse, they do not affect Maven, and you cannot define them in settings.xml.

Anyway, I've just noticed that you no longer need to modify POMs as of m2e 1.2. You can now define the lifecycle mappings in a workspace config file or from the IDE via Window | Preferences | Maven | Lifecycle Mappings.

(Editing the POMs is still possible and has the advantage of providing the settings in a central place, as opposed to everyone having to modify their workspace. OTOH, I do agree it's not really nice or intuitive to have IDE specific settings in the POMs.)

So I attach a second version of the patch that does not add any m2e lifecycle mappings to the POMs. Instead, there's a file etc/eclipse/lifecycle-mapping.xml which needs to be merged with any mappings the user already has in their workspace.
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.2.patch, TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508757#comment-13508757 ] 

Harald Wellmann commented on TOMEE-623:
---------------------------------------

Fine - I'm currently working on removing all the m2e errors. When I'm done, I'll attach a patch.
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Jean-Louis MONTEIRO (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508736#comment-13508736 ] 

Jean-Louis MONTEIRO commented on TOMEE-623:
-------------------------------------------

Hi, 

I guess almost all of us actually use IntelliJ.
Jon is using Eclipse AFAIR.

If you have a patch to attach, we can definitely commit it for you if that makes contribution easier with Eclipse and m2E.

JLouis

                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Romain Manni-Bucau (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509140#comment-13509140 ] 

Romain Manni-Bucau commented on TOMEE-623:
------------------------------------------

but it shouldn't be in the pom, just the settings.xml, no?
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509062#comment-13509062 ] 

Harald Wellmann commented on TOMEE-623:
---------------------------------------

The patch is for trunk@1416381.
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Romain Manni-Bucau (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510049#comment-13510049 ] 

Romain Manni-Bucau commented on TOMEE-623:
------------------------------------------

thank you very much!

if a lot of eclipse users start to hack we'll probably integrate them directly in the pom i think


                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.2.patch, TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509061#comment-13509061 ] 

Harald Wellmann commented on TOMEE-623:
---------------------------------------

With the attached patch, openjpa/openjpa and all subprojects can be imported into Eclipse + m2e without errors.

Precondition: The OpenJPA m2e extension is installed .- see https://github.com/hwellmann/m2eclipse-extras/wiki.

In addition to the m2e lifecycle additions, the patch also fixes some compiler errors (mainly package names not matching the directory name). ecj appears to be pickier than javac.
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Romain Manni-Bucau (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509084#comment-13509084 ] 

Romain Manni-Bucau commented on TOMEE-623:
------------------------------------------

Hi,

i'm not fan to force users to use plugins for eclipse. can't it be done in settings.xml?
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harald Wellmann updated TOMEE-623:
----------------------------------

    Attachment: TOMEE-623.2.patch
    
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.2.patch, TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509124#comment-13509124 ] 

Harald Wellmann commented on TOMEE-623:
---------------------------------------

Do you mean the OpenJPA m2e extension?

I'm afraid that's the way m2e is designed. If you don't install the extension, you have to add an ignore action for the openjpa-maven-plugin, and your entity classes won't get enhanced automatically when you edit a source file in Eclipse.
                
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TOMEE-623) Make TomEE m2e-friendly

Posted by "Harald Wellmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TOMEE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harald Wellmann updated TOMEE-623:
----------------------------------

    Attachment: TOMEE-623.patch
    
> Make TomEE m2e-friendly
> -----------------------
>
>                 Key: TOMEE-623
>                 URL: https://issues.apache.org/jira/browse/TOMEE-623
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Harald Wellmann
>             Fix For: 1.5.1
>
>         Attachments: TOMEE-623.patch
>
>
> Use Case
> * You are working with Eclipse Indigo or Juno and the latest m2e release for Maven support.
> * You want to import the TomEE/OpenEJB source tree to start hacking TomEE.
> Problem
> * Most subprojects have error markers caused by Maven plugins unknown to m2e.
> Solution:
> * Configure the org.eclipse.m2e:lifecycle-mapping Maven plugin in the pluginManagement section of the OpenEJB parent POM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira