[GitHub] [geode] boglesby commented on a change in pull request #7159: GEODE-9865: Decrement the count if the connection is unsuccessful

[GitBox <gi...@apache.org>]

boglesby commented on a change in pull request #7159:
URL: https://github.com/apache/geode/pull/7159#discussion_r761405567



##########
File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/pooling/ConnectionManagerImpl.java
##########
@@ -211,11 +211,17 @@ private PooledConnection createPooledConnection(ServerLocation serverLocation)
    */
   private PooledConnection forceCreateConnection(ServerLocation serverLocation)
       throws ServerRefusedConnectionException, ServerOperationException {
+    PooledConnection connection = null;
     connectionAccounting.create();
     try {
-      return createPooledConnection(serverLocation);
+      connection = createPooledConnection(serverLocation);
+      return connection;

Review comment:
       My original fix had the create in a finally if the connection was successfully created. During our meeting regarding this issue yesterday, it came up that this changed the behavior of the original code which was:
   
    1. increment the count before the connection is created
    2. create the connection
   
   So, I changed the fix to do exactly what it used to do with the addition of the finally block to undo the increment if the connection failed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org