[GitHub] spark pull request: [SPARK-4730][YARN] Warn against deprecated YAR...

[zuxqoj <gi...@git.apache.org>]

Github user zuxqoj commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3590#discussion_r25155375
  
    --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala ---
    @@ -78,11 +79,25 @@ private[spark] class YarnClientSchedulerBackend(
             ("--queue", "SPARK_YARN_QUEUE", "spark.yarn.queue"),
             ("--name", "SPARK_YARN_APP_NAME", "spark.app.name")
           )
    +    // Warn against the following deprecated environment variables: env var -> suggestion
    +    val deprecatedEnvVars = Map(
    +      "SPARK_MASTER_MEMORY" -> "SPARK_DRIVER_MEMORY or --driver-memory through spark-submit",
    +      "SPARK_WORKER_INSTANCES" -> "SPARK_WORKER_INSTANCES or --num-executors through spark-submit",
    +      "SPARK_WORKER_MEMORY" -> "SPARK_EXECUTOR_MEMORY or --executor-memory through spark-submit",
    +      "SPARK_WORKER_CORES" -> "SPARK_EXECUTOR_CORES or --executor-cores through spark-submit")
    +    // Do the same for deprecated properties: property -> suggestion
    +    val deprecatedProps = Map("spark.master.memory" -> "--driver-memory through spark-submit")
    --- End diff --
    
    SPARK_MASTER_MEMORY and spark.master.memory are not applicable in yarn-client mode
    
    should be removed, please refer SPARK-1953


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org