[GitHub] [incubator-doris] morningman commented on a change in pull request #5299: [BackupAndRestore] Support backup and restore view and external odbc table

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5299:
URL: https://github.com/apache/incubator-doris/pull/5299#discussion_r565254061



##########
File path: fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
##########
@@ -843,6 +930,15 @@ public void readFields(DataInput in) throws IOException {
         if (in.readBoolean()) {
             localJobInfoFilePath = Text.readString(in);
         }
+
+        if (Catalog.getCurrentCatalogJournalVersion() < FeMetaVersion.VERSION_95) {
+            return;
+        }
+        // read properties
+        size = in.readInt();
+        for (int i = 0; i < size; i++) {
+            properties.put(Text.readString(in), Text.readString(in));

Review comment:
       better deser key and value line by line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org