You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nadyaA <gi...@git.apache.org> on 2014/04/11 16:56:45 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
GitHub user nadyaA opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38
Make InAppBrowser work with embedded files, using system behavior
http://teampulse.telerik.com/view#item/257913
The plugin is changed to work with embedded files, using the system behavior. If one needs the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser for WP8 does not handle by itself the embedded pdf files, system behavior is called.
The plugin also is tested and working for wp7
https://issues.apache.org/jira/browse/CB-6405
Also this PR solves null reference exception, if no "options" are provided:
WP8: InAppBrowser NullReferenceException when the "options" param not passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugin-inappbrowser wp8-work-with-embedded-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit fb414268b298d2a7950bcfe19d96d28bc171e406
Author: Nadya Atanasova <na...@gmail.com>
Date: 2014-04-11T14:34:33Z
Make InAppBrowser work with embedded files, using system behavior
http://teampulse.telerik.com/view#item/257913
The plugin is changed to work with embedded files, using the system behavior. If one needs the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser for WP8 does not handle by itself the embedded pdf files, system behavior is called.
The plugin also is tested and working for wp7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by nadyaA <gi...@git.apache.org>.
Github user nadyaA commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40337912
Hello Jesse,
Yes, that is me.
Thank you for your quick answer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by nadyaA <gi...@git.apache.org>.
Github user nadyaA commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40458002
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40432983
I have merged your code into the dev branch, so this should close once it gets merged to master and published,
Note: I added 'await' calls to Launcher.LaunchUriAsync, to avoid 'harmless' warnings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40234237
Thank you Nadya,
Do you have an CLA on file? I see a Nadezhda Atanasova listed here: https://people.apache.org/committer-index.html
Is that you?
If not you will need to submit a signed CLA before I can pull in this fix.
details here: http://cordova.apache.org/#contribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by nadyaA <gi...@git.apache.org>.
GitHub user nadyaA reopened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38
Make InAppBrowser work with embedded files, using system behavior
The plugin is changed to work with embedded files, using the system behavior. If one needs the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser for WP8 does not handle by itself the embedded pdf files, system behavior is called.
The plugin also is tested and working for wp7
https://issues.apache.org/jira/browse/CB-6405
Also this PR solves null reference exception, if no "options" are provided:
https://issues.apache.org/jira/browse/CB-6402
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugin-inappbrowser wp8-work-with-embedded-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 2fc9f3da1fc683442a4c41811e826476d2ca9dd6
Author: Nadya Atanasova <na...@gmail.com>
Date: 2014-04-11T14:57:45Z
Make InAppBrowser work with embedded files, using system behavior
The plugin is changed to work with embedded files, using the system behavior. If one needs the system behavior, they need to pass "_system" as target when using the plugin. As the InAppBrowser for WP8 does not handle by itself the embedded pdf files, system behavior is called.
The plugin also is tested and working for wp7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...
Posted by nadyaA <gi...@git.apache.org>.
Github user nadyaA closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---