You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "kz930 (via GitHub)" <gi...@apache.org> on 2026/08/25 07:45:35 UTC
[PR] feat(treeplot): declare igraph so the Tree Plot operator can run [texera]
kz930 opened a new pull request, #7970:
URL: https://github.com/apache/texera/pull/7970
### What changes were proposed in this PR?
Adds `igraph==1.0.0` to `amber/operator-requirements.txt`. The Tree Plot operator's
generated Python template imports igraph, but the package was not declared in any of
the repository's Python dependency files, so an environment built from them could
never run the operator.
### Any related issues, documentation, discussions?
Closes #7969
### How was this PR tested?
Built a workflow of CSV File Scan into Tree Plot against a virtualenv created from the
repository requirements. It failed with `No module named 'igraph'`. Installing igraph
1.0.0 into that same environment made the identical workflow render the tree, with no
other change.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(treeplot): declare igraph so the Tree Plot operator can run [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 closed pull request #7970: feat(treeplot): declare igraph so the Tree Plot operator can run
URL: https://github.com/apache/texera/pull/7970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(treeplot): declare igraph so the Tree Plot operator can run [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7970:
URL: https://github.com/apache/texera/pull/7970#issuecomment-5407183833
### :warning: JUnit XML file not found
The CLI was unable to find any JUnit XML files to upload.
For more help, visit our [troubleshooting guide](https://docs.codecov.com/docs/test-analytics#troubleshooting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(treeplot): declare igraph so the Tree Plot operator can run [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7970:
URL: https://github.com/apache/texera/pull/7970#issuecomment-5407216677
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 4 better · 🔴 1 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `2c2c0e5` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/32823156890)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🟢 | bs=10 sw=10 sl=64 | 425 | 0.26 | 22,916/28,983/28,983 us | 🟢 -7.8% / 🔴 +106.0% |
| 🔴 | bs=100 sw=10 sl=64 | 941 | 0.575 | 105,822/123,674/123,674 us | 🟢 -12.1% / 🔴 +28.2% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,100 | 0.671 | 914,881/972,639/972,639 us | ⚪ within ±5% / ⚪ within ±5% |
<details><summary>Baseline details</summary>
Latest main `2c2c0e5` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 425 tuples/sec | 430 tuples/sec | 863.81 tuples/sec | -1.2% | -50.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.26 MB/s | 0.263 MB/s | 0.527 MB/s | -1.1% | -50.7% |
| bs=10 sw=10 sl=64 | p50 | 22,916 us | 23,851 us | 11,488 us | -3.9% | +99.5% |
| bs=10 sw=10 sl=64 | p95 | 28,983 us | 31,432 us | 14,067 us | -7.8% | +106.0% |
| bs=10 sw=10 sl=64 | p99 | 28,983 us | 31,432 us | 17,591 us | -7.8% | +64.8% |
| bs=100 sw=10 sl=64 | throughput | 941 tuples/sec | 958 tuples/sec | 1,127 tuples/sec | -1.8% | -16.5% |
| bs=100 sw=10 sl=64 | MB/s | 0.575 MB/s | 0.585 MB/s | 0.688 MB/s | -1.7% | -16.4% |
| bs=100 sw=10 sl=64 | p50 | 105,822 us | 100,104 us | 89,893 us | +5.7% | +17.7% |
| bs=100 sw=10 sl=64 | p95 | 123,674 us | 140,677 us | 96,506 us | -12.1% | +28.2% |
| bs=100 sw=10 sl=64 | p99 | 123,674 us | 140,677 us | 104,915 us | -12.1% | +17.9% |
| bs=1000 sw=10 sl=64 | throughput | 1,100 tuples/sec | 1,107 tuples/sec | 1,156 tuples/sec | -0.6% | -4.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.671 MB/s | 0.676 MB/s | 0.705 MB/s | -0.7% | -4.9% |
| bs=1000 sw=10 sl=64 | p50 | 914,881 us | 900,092 us | 886,448 us | +1.6% | +3.2% |
| bs=1000 sw=10 sl=64 | p95 | 972,639 us | 997,130 us | 930,093 us | -2.5% | +4.6% |
| bs=1000 sw=10 sl=64 | p99 | 972,639 us | 997,130 us | 963,104 us | -2.5% | +1.0% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,470.20,200,128000,425,0.260,22916.03,28982.59,28982.59
1,100,10,64,20,2124.80,2000,1280000,941,0.575,105821.75,123673.52,123673.52
2,1000,10,64,20,18179.98,20000,12800000,1100,0.671,914880.64,972638.79,972638.79
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(treeplot): declare igraph so the Tree Plot operator can run [texera]
Posted by "kz930 (via GitHub)" <gi...@apache.org>.
kz930 commented on PR #7970:
URL: https://github.com/apache/texera/pull/7970#issuecomment-5416183483
Closing this. igraph is GPL v2, which is Category X under the ASF 3rd Party License Policy, so it cannot be declared in amber/operator-requirements.txt at all, and check_binary_deps.py is right to reject it. I have rewritten #7969 with the licensing detail and the precedent from #4084 and #4090, so the remedy can be decided there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(treeplot): declare igraph so the Tree Plot operator can run [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7970:
URL: https://github.com/apache/texera/pull/7970#issuecomment-5407159364
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@renovate-bot`
You can notify them by mentioning `@renovate-bot` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org