You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/07/26 05:14:36 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #11181: Fix compat test by adding -am flag to build pinot-integration-tests
xiangfu0 opened a new pull request, #11181:
URL: https://github.com/apache/pinot/pull/11181
use `-am` flag to ensure the related components are built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #11181: Fix compat test by adding -am flag to build pinot-integration-tests
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11181:
URL: https://github.com/apache/pinot/pull/11181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] robertzych commented on a diff in pull request #11181: Fix compat test by adding -am flag to build pinot-integration-tests
Posted by "robertzych (via GitHub)" <gi...@apache.org>.
robertzych commented on code in PR #11181:
URL: https://github.com/apache/pinot/pull/11181#discussion_r1274929986
##########
compatibility-verifier/checkoutAndBuild.sh:
##########
@@ -99,14 +99,14 @@ function build() {
if [ $? -eq 0 ]; then break; fi
if [ $i -eq $maxRetry ]; then exit 1; fi
echo ""
- echo "Build failed, see last 1000 lines of output below."
+ echo "Build failed, see lamast 1000 lines of output below."
Review Comment:
(minor) Please correct this typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11181: Fix compat test by adding -am flag to build pinot-integration-tests
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11181:
URL: https://github.com/apache/pinot/pull/11181#issuecomment-1651021720
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11181](https://app.codecov.io/gh/apache/pinot/pull/11181?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6bed52c) into [master](https://app.codecov.io/gh/apache/pinot/commit/9e079b1da94e9b3b980a3a4df4807e8091bc681f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9e079b1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11181 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2214 2159 -55
Lines 118822 116298 -2524
Branches 17978 17671 -307
=========================================
Hits 137 137
+ Misses 118665 116141 -2524
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `0.11% <ø> (ø)` | |
| unittests2temurin17 | `0.11% <ø> (ø)` | |
| unittests2temurin20 | `0.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 55 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11181/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org