You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/08 09:50:24 UTC
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries
JingsongLi commented on code in PR #111:
URL: https://github.com/apache/flink-table-store/pull/111#discussion_r867464932
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -61,6 +66,13 @@
@Nullable private final Predicate fieldPredicate;
+ /** The latest snapshot id seen at planning phase when manual compaction is triggered. */
+ @Nullable private final Long specifiedSnapshotId;
+
+ /** The manifest entries collected at planning phase when manual compaction is triggered. */
+ @Nullable
+ private final Map<BinaryRowData, Map<Integer, List<DataFileMeta>>> specifiedManifestEntries;
Review Comment:
`DataFileMeta` is not serializable, but `FileStoreSource ` is.
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -61,6 +66,13 @@
@Nullable private final Predicate fieldPredicate;
+ /** The latest snapshot id seen at planning phase when manual compaction is triggered. */
+ @Nullable private final Long specifiedSnapshotId;
+
+ /** The manifest entries collected at planning phase when manual compaction is triggered. */
+ @Nullable
+ private final Map<BinaryRowData, Map<Integer, List<DataFileMeta>>> specifiedManifestEntries;
Review Comment:
`DataFileMeta` is not serializable, but `FileStoreSource` is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org