[GitHub] [cassandra] JeremiahDJordan commented on a diff in pull request #2310: CASSANDRA-18504: Added support for type VECTOR

["JeremiahDJordan (via GitHub)" <gi...@apache.org>]

JeremiahDJordan commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1205700290


##########
src/java/org/apache/cassandra/cql3/CQL3Type.java:
##########
@@ -34,7 +34,6 @@
 import org.apache.cassandra.schema.Types;
 import org.apache.cassandra.serializers.CollectionSerializer;
 import org.apache.cassandra.serializers.MarshalException;
-import org.apache.cassandra.transport.ProtocolVersion;

Review Comment:
   Do we really want to lose the ability to have version specific encodings?  Such that if we want it again because we change someone in 5.1 someone has to go and undo all these changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org