You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/11 01:01:11 UTC

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

masayuki2009 opened a new pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291


   ## Summary
   
   - This PR fixes compile warnings in nxrecorder.c
   
   ## Impact
   
   - This PR affects nxrecorder only.
   
   ## Testing
   
   - I tested this PR with spresense:wifi (need to add nxrecorder to defconfig)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291#issuecomment-642347846


   > Ok, I'll merge this now since the fix is minor and the CI system wont capture this anyway.
   
   @btashton 
   Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291#issuecomment-642347523


   Ok, I'll merge this now since the fix is minor and the CI system wont capture this anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291#issuecomment-642346582


   > @masayuki2009 Can we add this to a defconfig as well that way we can get better coverage on the CI for this?
   
   @btashton 
   Yes. I will send another PR to the nuttx after this PR is merged.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291#issuecomment-642345863


   @masayuki2009 Can we add this to a defconfig as well that way we can get better coverage on the CI for this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291#issuecomment-642346582


   > @masayuki2009 Can we add this to a defconfig as well that way we can get better coverage on the CI for this?
   
   Yes. I will send another PR to the nuttx after this PR is merged.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton merged pull request #291: system: nxrecorder: Fix compile warnings in nxrecorder.c

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #291:
URL: https://github.com/apache/incubator-nuttx-apps/pull/291


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org