You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "sinberCS (via GitHub)" <gi...@apache.org> on 2026/01/19 10:15:32 UTC
[PR] [ISSUE #10009] Add null-check log and Convert internal-only public classes to inner classes [rocketmq]
sinberCS opened a new pull request, #10028:
URL: https://github.com/apache/rocketmq/pull/10028
Fixes <https://github.com/apache/rocketmq/issues/10009#10009>
Although the NPE (NullPointerException) issue mentioned in the issue report shouldn't occur under theoretical circumstances.
For defensive programming purposes, I added a null check at the specified location and changed the internal-only public class to an inner class.I added a null check at the specified location and changed the internal-only public class to an inner class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10009] Add null-check log and Convert internal-only public classes to inner classes [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10028:
URL: https://github.com/apache/rocketmq/pull/10028#issuecomment-3767878083
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10028?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.00000%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.88%. Comparing base ([`ee10411`](https://app.codecov.io/gh/apache/rocketmq/commit/ee104114ac822e02aabd55f3a14d3609bee3e6b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51c5781`](https://app.codecov.io/gh/apache/rocketmq/commit/51c57819743123bdbaa06f5fdac7f648f2a2287e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/10028?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...cketmq/broker/schedule/ScheduleMessageService.java](https://app.codecov.io/gh/apache/rocketmq/pull/10028?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fschedule%2FScheduleMessageService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2NoZWR1bGUvU2NoZWR1bGVNZXNzYWdlU2VydmljZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10028?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10028 +/- ##
=============================================
- Coverage 49.03% 48.88% -0.15%
+ Complexity 13365 13327 -38
=============================================
Files 1373 1373
Lines 99682 99685 +3
Branches 12884 12885 +1
=============================================
- Hits 48877 48731 -146
- Misses 44906 45036 +130
- Partials 5899 5918 +19
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/10028?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10009] Add null-check log and Convert internal-only public classes to inner classes [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #10028:
URL: https://github.com/apache/rocketmq/pull/10028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org