You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/07/08 09:22:43 UTC

[GitHub] [hudi] garyli1019 commented on a change in pull request #3238: [HUDI-2143] Tweak the default compaction target IO to 500GB when flin…

garyli1019 commented on a change in pull request #3238:
URL: https://github.com/apache/hudi/pull/3238#discussion_r666022649



##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##########
@@ -199,6 +199,12 @@ private static void setupCleaningOptions(Configuration conf) {
       conf.setInteger(FlinkOptions.ARCHIVE_MIN_COMMITS, commitsToRetain + 10);
       conf.setInteger(FlinkOptions.ARCHIVE_MAX_COMMITS, commitsToRetain + 20);
     }
+    if (conf.getBoolean(FlinkOptions.COMPACTION_SCHEDULE_ENABLED)

Review comment:
       why not just respect the config user-defined? this change the config without noticing anyone




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org