You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/09/11 21:30:11 UTC
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4372
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
KUDU-1301 - [python] Tests leak tmp directory
In the past the python tests have been leaking tmp directories and
processes for the master and tablet servers. Previously, with
change http://gerrit.cloudera.org:8080/#/c/1817/, the check for
temp leak was disabled for python tests to avoid errors. This patch
fixes the leak and re-enables the leak check for python.
Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
2 files changed, 10 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/4372/1
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4372/1//COMMIT_MSG
Commit Message:
Line 11: commit 89380b53d48b085dfe394b9966360d1ef1a4b038, the check for
> nit: better to mention it by its commit hash (since in 5 years the gerrit s
Done
Line 13: fixes both the temp directory and the process leak and re-enables
> does it also fix the process leak?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3358/
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4372
to look at the new patch set (#2).
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
KUDU-1301 - [python] Tests leak tmp directory
In the past the python tests have been leaking tmp directories and
processes for the master and tablet servers. Previously, with
commit 89380b53d48b085dfe394b9966360d1ef1a4b038, the check for
temp leak was disabled for python tests to avoid errors. This patch
fixes both the temp directory and the process leak and re-enables
the leak check for python.
Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
2 files changed, 10 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/4372/2
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3351/
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4372/1//COMMIT_MSG
Commit Message:
Line 11: change http://gerrit.cloudera.org:8080/#/c/1817/, the check for
nit: better to mention it by its commit hash (since in 5 years the gerrit server might have changed URLs, but git is forever)
Line 13: fixes the leak and re-enables the leak check for python.
does it also fix the process leak?
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1301 - [python] Tests leak tmp directory
......................................................................
KUDU-1301 - [python] Tests leak tmp directory
In the past the python tests have been leaking tmp directories and
processes for the master and tablet servers. Previously, with
commit 89380b53d48b085dfe394b9966360d1ef1a4b038, the check for
temp leak was disabled for python tests to avoid errors. This patch
fixes both the temp directory and the process leak and re-enables
the leak check for python.
Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Reviewed-on: http://gerrit.cloudera.org:8080/4372
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
2 files changed, 10 insertions(+), 18 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>