You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2023/03/21 17:18:00 UTC
[jira] [Commented] (CASSANDRA-17341) Merge guardrails and track warnings configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-17341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703308#comment-17703308 ]
Andres de la Peña commented on CASSANDRA-17341:
-----------------------------------------------
This seems to have already been done by CASSANDRA-17560, after settling on unnested yaml properties. We can probably close this as a duplicate of that ticket.
The only thing that seems a bit different between guardrails and track warnings is the placement of their JMX setters and getters. Track warnings uses {{{}StorageServiceMBean{}}}, whereas guardrails uses its own dedicated {{{}GuardrailsMBean{}}}.
Also, the global flag for enabling/disabling all guardrails was removed in CASSANDRA-17499 after long discussions. However it seems that [the analogous global flag for track warnings|https://github.com/apache/cassandra/blob/cassandra-4.1.0/conf/cassandra.yaml#L1651] has managed to survive, even when it seems the same case.
Nevertheless, both the JMX methods and the global flag have been shipped in 4.1, so we should probably keep them, at least for some time.
CC [~dcapwell]
> Merge guardrails and track warnings configurations
> --------------------------------------------------
>
> Key: CASSANDRA-17341
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17341
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Guardrails, Local/Config
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 5.x
>
>
> As discussed in CASSANDRA-17148, a first step for the integration between guardrails and track warnings is merging their configurations, which are almost identical. This ticket would cover merging their config sections in {{cassandra.yaml}} and their corresponding JMX getters and setters. A tighter integration between the internals of both features wouldn't be part of this ticket, but of either CASSANDRA-17148 or a new subtask of it.
> Neither guardrails nor track warnings have included in any release, so it would be desirable to do this before releasing 4.1 so we don't have to deprecate properties.
> There's an ongoing discussion about refactoring {{cassandra.yaml}} spread across CASSANDRA-17292, CASSANDRA-17188 and CASSANDRA-17212. I understand that any change affecting the config for guardrails also affects the config track warnings, because they are almost identical. Thus, I think that merging both config sections would ease any refactoring plan that is agreed on that discussion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org