You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "tom pierce (Created) (JIRA)" <ji...@apache.org> on 2012/03/08 04:09:31 UTC
[jira] [Created] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Our build is unstable - this should reduce our style warnings by >200
----------------------------------------------------------------------
Key: MAHOUT-987
URL: https://issues.apache.org/jira/browse/MAHOUT-987
Project: Mahout
Issue Type: Improvement
Affects Versions: 0.7
Reporter: tom pierce
Fix For: 0.7
If we're going to keep these Jenkins style rules, let's get our build stable!
Here's about 200 small fixes created by:
find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "Jeff Eastman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Eastman reassigned MAHOUT-987:
-----------------------------------
Assignee: tom pierce
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Assignee: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224968#comment-13224968 ]
jiraposter@reviews.apache.org commented on MAHOUT-987:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4238/
-----------------------------------------------------------
Review request for mahout.
Summary
-------
Generated with:
find . -name *java | xargs perl -pi -e 's/(if|while|for)(/$1 (/'
This addresses bug MAHOUT-987.
https://issues.apache.org/jira/browse/MAHOUT-987
Diffs
-----
trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/knn/ConjugateGradientOptimizer.java 1298262
trunk/core/src/main/java/org/apache/mahout/classifier/ConfusionMatrix.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/LDADriver.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/LDASampler.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CVB0DocInferenceMapper.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CVB0Driver.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0PerplexityMapper.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/InMemoryCollapsedVariationalBayes0.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/ModelTrainer.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java 1298262
trunk/core/src/main/java/org/apache/mahout/clustering/spectral/eigencuts/EigencutsDriver.java 1298262
trunk/core/src/main/java/org/apache/mahout/common/distance/MahalanobisDistanceMeasure.java 1298262
trunk/core/src/main/java/org/apache/mahout/math/DistributedRowMatrixWriter.java 1298262
trunk/core/src/main/java/org/apache/mahout/math/MatrixUtils.java 1298262
trunk/core/src/main/java/org/apache/mahout/math/hadoop/decomposer/DistributedLanczosSolver.java 1298262
trunk/core/src/main/java/org/apache/mahout/math/hadoop/decomposer/HdfsBackedLanczosState.java 1298262
trunk/core/src/main/java/org/apache/mahout/math/stats/Sampler.java 1298262
trunk/core/src/test/java/org/apache/mahout/clustering/ClusteringTestUtils.java 1298262
trunk/core/src/test/java/org/apache/mahout/clustering/lda/TestMapReduce.java 1298262
trunk/core/src/test/java/org/apache/mahout/clustering/lda/cvb/TestCVBModelTrainer.java 1298262
trunk/core/src/test/java/org/apache/mahout/common/distance/DefaultDistanceMeasureTest.java 1298262
trunk/core/src/test/java/org/apache/mahout/math/MatrixWritableTest.java 1298262
trunk/core/src/test/java/org/apache/mahout/math/hadoop/TestDistributedRowMatrix.java 1298262
trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolver.java 1298262
trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolverCLI.java 1298262
trunk/integration/src/main/java/org/apache/mahout/clustering/lda/LDAPrintTopics.java 1298262
trunk/integration/src/main/java/org/apache/mahout/utils/MatrixDumper.java 1298262
trunk/integration/src/main/java/org/apache/mahout/utils/vectors/VectorHelper.java 1298262
trunk/math/src/main/java/org/apache/mahout/math/decomposer/lanczos/LanczosSolver.java 1298262
trunk/math/src/main/java/org/apache/mahout/math/jet/stat/Gamma.java 1298262
trunk/math/src/main/java/org/apache/mahout/math/matrix/linalg/EigenvalueDecomposition.java 1298262
trunk/math/src/main/java/org/apache/mahout/math/matrix/linalg/Property.java 1298262
trunk/math/src/test/java/org/apache/mahout/math/MatrixTest.java 1298262
trunk/math/src/test/java/org/apache/mahout/math/TestSingularValueDecomposition.java 1298262
trunk/math/src/test/java/org/apache/mahout/math/decomposer/SolverTest.java 1298262
trunk/math/src/test/java/org/apache/mahout/math/decomposer/hebbian/TestHebbianSolver.java 1298262
trunk/math/src/test/java/org/apache/mahout/math/decomposer/lanczos/TestLanczosSolver.java 1298262
Diff: https://reviews.apache.org/r/4238/diff
Testing
-------
Thanks,
tom
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276160#comment-13276160 ]
Hudson commented on MAHOUT-987:
-------------------------------
Integrated in Mahout-Quality #1483 (See [https://builds.apache.org/job/Mahout-Quality/1483/])
MAHOUT-987: more whitespace fixes, also knocked out a few unneeded imports (Revision 1338525)
Result = SUCCESS
tcp : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338525
Files :
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/DatasetSplitter.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/RecommenderJob.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/item/ToUserVectorsReducer.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/preparation/PreparePreferenceMatrixJob.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/similarity/item/ItemSimilarityJob.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/svd/ImplicitLinearRegressionFactorizer.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/df/builder/DecisionTreeBuilder.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CVB0Driver.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/common/AbstractJob.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/math/hadoop/stochasticsvd/QJob.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/vectorizer/EncodedVectorsFromSequenceFiles.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/vectorizer/SparseVectorsFromSequenceFiles.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/hadoop/als/ParallelALSFactorizationJobTest.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/TopItemsTest.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/common/distance/DefaultDistanceMeasureTest.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/math/hadoop/stats/BasicStatsTest.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/cf/taste/example/email/MailToPrefsDriver.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/cf/taste/example/email/MsgIdToDictionaryMapper.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/df/mapreduce/BuildForest.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/email/PrepEmailMapper.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/naivebayes/TestNewsGroups.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/sgd/TestNewsGroups.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/SequenceFileDumper.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/clustering/GraphMLClusterWriter.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/email/MailProcessor.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/regex/RegexConverterDriver.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/vectors/VectorDumper.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/vectors/lucene/Driver.java
* /mahout/trunk/integration/src/test/java/org/apache/mahout/text/SequenceFilesFromMailArchivesTest.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/GenericPermuting.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/MurmurHash3.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/jet/math/Arithmetic.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/jet/random/Poisson.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/DoubleMatrix1D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/DoubleMatrix2D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/AbstractMatrix2D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/DenseDoubleMatrix1D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/DenseDoubleMatrix2D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/SparseDoubleMatrix2D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/impl/WrapperDoubleMatrix2D.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/matrix/linalg/Property.java
* /mahout/trunk/math/src/test/java/org/apache/mahout/math/stats/LogLikelihoodTest.java
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Assignee: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "Jeff Eastman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274816#comment-13274816 ]
Jeff Eastman commented on MAHOUT-987:
-------------------------------------
Hey Tom, those look like mostly whitespace changes. I'd hate to miss an opportunity to reduce our style warnings for 0.7. I'm going to assign this to you so it doesn't get flushed tomorrow.
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "tom pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
tom pierce updated MAHOUT-987:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Those 2 commits got us back to stable (woot!) and I'm not going to have any more time to spend on this before code freeze for 0.7, so I'm going to close this ticket.
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Assignee: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "tom pierce (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
tom pierce updated MAHOUT-987:
------------------------------
Status: Patch Available (was: Open)
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "tom pierce (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
tom pierce updated MAHOUT-987:
------------------------------
Attachment: MAHOUT-987.patch
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-987) Our build is unstable - this should
reduce our style warnings by >200
Posted by "tom pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274827#comment-13274827 ]
tom pierce commented on MAHOUT-987:
-----------------------------------
Hi Folks -
I've been heads-down on other things for a bit, and way behind on the
list. The code freeze date has snuck up on me, but I will try to get at
least one or two batches of style fixes in over the next 24 hrs.
Jeff, thanks for flagging this and causing it to bubble up on my radar!
-tom
> Our build is unstable - this should reduce our style warnings by >200
> ----------------------------------------------------------------------
>
> Key: MAHOUT-987
> URL: https://issues.apache.org/jira/browse/MAHOUT-987
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: tom pierce
> Assignee: tom pierce
> Fix For: 0.7
>
> Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira