You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by cheng xu <ch...@intel.com> on 2014/11/04 09:06:09 UTC

Review Request 27566: HIVE-8609: move beeline to jline2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs
-----

  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d56a3dbb922e917762e25267999ff9277ae 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a415b288af0e8f7ee1056932e40c0155e1ea 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6abc7974a9c2261063f19248f3293335d3 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4feb99f24074b69dff201b697ed2c1adeede 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb445aeff0052f43179a2314f3f342f72ea5f 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c531c761e9d42bc301fe1b4f1c22c5d0cbbd 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab17789b8b9d97b98ee3b64efa10fef48260af4 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc1d821a04d64f4e4923ebab2011e041a67 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700d3a83bc51902aa479f5f33ecb33401a47 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f20a63c17fd9decdfe4f2b2f92b30ecdb58 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae313e5d4cb5680d55a90255418b84155f9 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9beb62ccbb0bff88d65e5e72d12c6f6bbb3b 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d7a9b0ea6730e06637ac5796f173a9f99ea054c3 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 63668bca8a998c799002e0492866f80e0d730f0b 
  pom.xml a5f851f31df15660cebef0e4691ea34699c6d1ef 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 284acbc8ae70026ffb878de0f76921b4816737ba 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.

> On Nov. 10, 2014, 9:13 p.m., Brock Noland wrote:
> > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 32
> > <https://reviews.apache.org/r/27566/diff/1/?file=748191#file748191line32>
> >
> >     Is this new functionality?

In the previous code, it tried to use the ClassNameCompletor which is provided by the jline. In the latest version, we have to implement it by our own.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60674
-----------------------------------------------------------


On Nov. 4, 2014, 8:06 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 8:06 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d56a3dbb922e917762e25267999ff9277ae 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a415b288af0e8f7ee1056932e40c0155e1ea 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6abc7974a9c2261063f19248f3293335d3 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4feb99f24074b69dff201b697ed2c1adeede 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb445aeff0052f43179a2314f3f342f72ea5f 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c531c761e9d42bc301fe1b4f1c22c5d0cbbd 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab17789b8b9d97b98ee3b64efa10fef48260af4 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc1d821a04d64f4e4923ebab2011e041a67 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700d3a83bc51902aa479f5f33ecb33401a47 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f20a63c17fd9decdfe4f2b2f92b30ecdb58 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae313e5d4cb5680d55a90255418b84155f9 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9beb62ccbb0bff88d65e5e72d12c6f6bbb3b 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d7a9b0ea6730e06637ac5796f173a9f99ea054c3 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 63668bca8a998c799002e0492866f80e0d730f0b 
>   pom.xml a5f851f31df15660cebef0e4691ea34699c6d1ef 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 284acbc8ae70026ffb878de0f76921b4816737ba 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60674
-----------------------------------------------------------


Thank you! I have a few comments below...


beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java
<https://reviews.apache.org/r/27566/#comment102054>

    We need to cleanup the imports here



beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java
<https://reviews.apache.org/r/27566/#comment102055>

    Is this new functionality?



beeline/src/java/org/apache/hive/beeline/Commands.java
<https://reviews.apache.org/r/27566/#comment102052>

    Generally we don't use import .*


- Brock Noland


On Nov. 4, 2014, 8:06 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 8:06 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d56a3dbb922e917762e25267999ff9277ae 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a415b288af0e8f7ee1056932e40c0155e1ea 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6abc7974a9c2261063f19248f3293335d3 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4feb99f24074b69dff201b697ed2c1adeede 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb445aeff0052f43179a2314f3f342f72ea5f 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c531c761e9d42bc301fe1b4f1c22c5d0cbbd 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab17789b8b9d97b98ee3b64efa10fef48260af4 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc1d821a04d64f4e4923ebab2011e041a67 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700d3a83bc51902aa479f5f33ecb33401a47 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f20a63c17fd9decdfe4f2b2f92b30ecdb58 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae313e5d4cb5680d55a90255418b84155f9 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9beb62ccbb0bff88d65e5e72d12c6f6bbb3b 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d7a9b0ea6730e06637ac5796f173a9f99ea054c3 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 63668bca8a998c799002e0492866f80e0d730f0b 
>   pom.xml a5f851f31df15660cebef0e4691ea34699c6d1ef 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 284acbc8ae70026ffb878de0f76921b4816737ba 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.

> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 1
> > <https://reviews.apache.org/r/27566/diff/2/?file=757659#file757659line1>
> >
> >     I see, this class is being copied from JLine source. We'll need special handling of this class.
> >     
> >     (1) We need to add the original license BSD-2 to the top of the file with the apache license below it.
> >     
> >     (2) We need to add a section to the top level license file, in the style of: https://github.com/apache/hive/blob/trunk/LICENSE#L212
> >     
> >     (3) We should consider reformatting the file to comply with hive standards
> >     
> >     Note that my specific example has been removed and as such we need to remove it from the top level license file. I filed HIVE-8826 to do that. Should be an easy fix.

Thank Brock for your kind remind.
(1) The original license to the top of the file added
(2) JLine part is already added, does this file need a standalone section in this license file?
(3) Formatted in HIVE code style.


> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > hcatalog/hcatalog-pig-adapter/pom.xml, line 57
> > <https://reviews.apache.org/r/27566/diff/2/?file=757669#file757669line57>
> >
> >     I am not 100% sure this will work, let's see.

Test locally already, anyway, still wait for the CI result :)


> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > beeline/src/java/org/apache/hive/beeline/SQLCompleter.java, line 53
> > <https://reviews.apache.org/r/27566/diff/2/?file=757664#file757664line53>
> >
> >     Wow, this is not good. I created HIVE-8825 to fix catching Throwable. Should be quick fix.

Let's do it in HIVE-8825 Once this patch ready.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60788
-----------------------------------------------------------


On Nov. 11, 2014, 11:45 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 11:45 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.

> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 1
> > <https://reviews.apache.org/r/27566/diff/2/?file=757659#file757659line1>
> >
> >     I see, this class is being copied from JLine source. We'll need special handling of this class.
> >     
> >     (1) We need to add the original license BSD-2 to the top of the file with the apache license below it.
> >     
> >     (2) We need to add a section to the top level license file, in the style of: https://github.com/apache/hive/blob/trunk/LICENSE#L212
> >     
> >     (3) We should consider reformatting the file to comply with hive standards
> >     
> >     Note that my specific example has been removed and as such we need to remove it from the top level license file. I filed HIVE-8826 to do that. Should be an easy fix.
> 
> cheng xu wrote:
>     Thank Brock for your kind remind.
>     (1) The original license to the top of the file added
>     (2) JLine part is already added, does this file need a standalone section in this license file?
>     (3) Formatted in HIVE code style.

I saw one example in license file, add this license for the specified class "ClassNameCompleter", answering my second item. Mark this issue as fixed with license added for ClassNameCompeter file.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60788
-----------------------------------------------------------


On Nov. 12, 2014, 2:30 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 2:30 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60788
-----------------------------------------------------------


Thank you very much! I have made some more comments below! Lets see how the tests go.


beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java
<https://reviews.apache.org/r/27566/#comment102202>

    I see, this class is being copied from JLine source. We'll need special handling of this class.
    
    (1) We need to add the original license BSD-2 to the top of the file with the apache license below it.
    
    (2) We need to add a section to the top level license file, in the style of: https://github.com/apache/hive/blob/trunk/LICENSE#L212
    
    (3) We should consider reformatting the file to comply with hive standards
    
    Note that my specific example has been removed and as such we need to remove it from the top level license file. I filed HIVE-8826 to do that. Should be an easy fix.



beeline/src/java/org/apache/hive/beeline/SQLCompleter.java
<https://reviews.apache.org/r/27566/#comment102200>

    Wow, this is not good. I created HIVE-8825 to fix catching Throwable. Should be quick fix.



hcatalog/hcatalog-pig-adapter/pom.xml
<https://reviews.apache.org/r/27566/#comment102201>

    I am not 100% sure this will work, let's see.


- Brock Noland


On Nov. 11, 2014, 11:45 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 11:45 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.

> On Nov. 13, 2014, 2:06 a.m., Mohit Sabharwal wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java, line 35
> > <https://reviews.apache.org/r/27566/diff/4/?file=759115#file759115line35>
> >
> >     nit: add @Override

The override keyword is not applicable here since it's newly created in this class.


> On Nov. 13, 2014, 2:06 a.m., Mohit Sabharwal wrote:
> > hcatalog/hcatalog-pig-adapter/pom.xml, line 59
> > <https://reviews.apache.org/r/27566/diff/4/?file=759132#file759132line59>
> >
> >     2.12 ?

I am afraid not, since pig is using old versioned jline. To pass the UT, we have make it to 0.9.94.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60811
-----------------------------------------------------------


On Nov. 12, 2014, 2:43 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 2:43 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   LICENSE 2885945 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60811
-----------------------------------------------------------


Few requests to improve docs, otherwise LGTM!


beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java
<https://reviews.apache.org/r/27566/#comment102221>

    extra ;



LICENSE
<https://reviews.apache.org/r/27566/#comment102583>

    extra word "contains"



beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java
<https://reviews.apache.org/r/27566/#comment102619>

    nit: add @Override



beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java
<https://reviews.apache.org/r/27566/#comment102667>

    While we're here: 
      Could we rename "compl" to "embeddedCompleters"?   Also, it's more readable if we get rid of "comps" and just add it directly (since it's not used anywhere else)



beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java
<https://reviews.apache.org/r/27566/#comment102671>

    extra ;



beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java
<https://reviews.apache.org/r/27566/#comment102672>

    nit: extra lines



beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java
<https://reviews.apache.org/r/27566/#comment102637>

    While we're here, could we please add javadoc. In particular, clarify that 'cmds' is an array of alternative names for the same command. And that the first one is always chosen for display purposes and to lookup help documentation from BeeLine.properties file.



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102680>

    move this under jline imports



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102682>

    let's rename this to strCompleter



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102676>

    Import jline.console.completer.ArgumentCompleter.ArgumentDelimiter



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102681>

    let's rename this to argCompleter



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102687>

    let's rename to customCompleter



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102691>

    setCompleter



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/27566/#comment102692>

    confCompleter



hcatalog/hcatalog-pig-adapter/pom.xml
<https://reviews.apache.org/r/27566/#comment102695>

    2.12 ?



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java
<https://reviews.apache.org/r/27566/#comment102697>

    move down with other jline imports


- Mohit Sabharwal


On Nov. 12, 2014, 2:43 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 2:43 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   LICENSE 2885945 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review61777
-----------------------------------------------------------

Ship it!



LICENSE
<https://reviews.apache.org/r/27566/#comment103666>

    Please remove the word "contains". It's not part of the license.



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/27566/#comment103668>

    move import up in jline section


- Mohit Sabharwal


On Nov. 13, 2014, 4:29 p.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 4:29 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   LICENSE 2885945 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

(Updated Nov. 13, 2014, 4:29 p.m.)


Review request for hive.


Changes
-------

Fixed failed cases according to previous changes in diff5


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs (updated)
-----

  LICENSE 2885945 
  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
  beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
  beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
  hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
  pom.xml ec8c4fe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

(Updated Nov. 13, 2014, 3:44 a.m.)


Review request for hive.


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs (updated)
-----

  LICENSE 2885945 
  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
  beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
  beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
  hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
  pom.xml ec8c4fe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

(Updated Nov. 13, 2014, 3:35 a.m.)


Review request for hive.


Changes
-------

The new diff consists of:
1. update the code style and javadoc issue
2. fix shutdown hook to persist the history log
3. disable Event Designators for the backward compatibility.


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs (updated)
-----

  LICENSE 2885945 
  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
  beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
  beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
  hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
  pom.xml ec8c4fe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 2:43 a.m.)


Review request for hive.


Changes
-------

The new diff includes that:
(1) add license for ClassNameCompleter in the License file


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs (updated)
-----

  LICENSE 2885945 
  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
  beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
  beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
  hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
  pom.xml ec8c4fe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 2:30 a.m.)


Review request for hive.


Changes
-------

The new diff includes the following changes:
(1) add license for ClassNameCompleter
(2) format the ClassNameCompleter.java file by HIVE code format


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
  beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
  beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
  hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
  pom.xml ec8c4fe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu


Re: Review Request 27566: HIVE-8609: move beeline to jline2

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/
-----------------------------------------------------------

(Updated Nov. 11, 2014, 11:45 a.m.)


Review request for hive.


Changes
-------

1. fix stty echo disabled issues by initializing the terminal once
2. fix some minor issues pointing by Brock
3. fix failed unit test


Repository: hive-git


Description
-------

HIVE-8609: move beeline to jline2
The following will be changed:
* MultiCompletor-> AggregateCompleter
* SimpleCompletor->StringsCompleter
* Terminal.getTerminalWidth() -> Terminal.getWidth()
* Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
* String -> CharSequence


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
  beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
  beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
  beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
  beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
  beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
  beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
  beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
  hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
  pom.xml ec8c4fe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 

Diff: https://reviews.apache.org/r/27566/diff/


Testing
-------


Thanks,

cheng xu