You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/25 18:30:15 UTC

[GitHub] [kafka] wcarlson5 opened a new pull request #11258: MINOR: add to empty, remove then add different test

wcarlson5 opened a new pull request #11258:
URL: https://github.com/apache/kafka/pull/11258


   add a test for named topology
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] wcarlson5 commented on pull request #11258: MINOR: add to empty, remove then add different test

Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #11258:
URL: https://github.com/apache/kafka/pull/11258#issuecomment-905910457


   @ableegoldman whatever works best for you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #11258: MINOR: add to empty, remove then add different test

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11258:
URL: https://github.com/apache/kafka/pull/11258#issuecomment-905900986


   Sounds like this is waiting on the blocking functionality coming in Pt. 4 -- thanks for the test, do you want to just leave this PR until Pt. 4 is merged and then make sure it passes? Alternatively I can copy this over to the Pt. 4 PR and merge it with that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman closed pull request #11258: MINOR: add to empty, remove then add different test

Posted by GitBox <gi...@apache.org>.
ableegoldman closed pull request #11258:
URL: https://github.com/apache/kafka/pull/11258


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #11258: MINOR: add to empty, remove then add different test

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11258:
URL: https://github.com/apache/kafka/pull/11258#issuecomment-922450377


   Copied over to the Pt. 4 PR so we can make sure this passes by the time Pt. 4 is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org