[jira] [Commented] (MINIFICPP-510) Default property log msg is at wrong level (error vs. info)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490770#comment-16490770 ] 

ASF GitHub Bot commented on MINIFICPP-510:
------------------------------------------

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/343

    MINIFICPP-510 Fix log level when notifying of usage of default values

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #343
    
----
commit f13bc50336a25341aec8d5e8a89b0519ced2b376
Author: Andrew I. Christianson <an...@...>
Date:   2018-05-25T14:10:02Z

    MINIFICPP-510 Fix log level when notifying of usage of default values

----


> Default property log msg is at wrong level (error vs. info)
> -----------------------------------------------------------
>
>                 Key: MINIFICPP-510
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-510
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Config log messages for using default value are at error level, which is incorrect and misleading when monitoring logs. These messages should be at info level because relying on a default config value is a completely non-exceptional use case.
> {code:java}
> [error] Using default value for optional field 'scheduling period' in component named 'XYZ' [in 'Processors' section of configuration file]{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)