You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/21 11:19:18 UTC
[GitHub] [spark] panbingkun opened a new pull request, #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
panbingkun opened a new pull request, #37598:
URL: https://github.com/apache/spark/pull/37598
### What changes were proposed in this pull request?
This PR test updates plugins to latest versions.
### Why are the changes needed?
This brings improvment & bug fixes like the following:
- 1.scalacheck (from 1.15.4 to 1.16.0)
https://github.com/typelevel/scalacheck/releases
https://github.com/typelevel/scalacheck/compare/1.15.4...v1.16.0
https://github.com/typelevel/scalacheck/commit/2ae1be5c8e5ee1c14abea607d631e334a56796de
https://github.com/typelevel/scalacheck/commit/902121e498e59b5151066a6c1794cdf47a31428f
- 2.maven-surefire-plugin (from 3.0.0-M5 to 3.0.0-M7)
https://github.com/apache/maven-surefire/releases
https://github.com/apache/maven-surefire/compare/surefire-3.0.0-M5...surefire-3.0.0-M7
- 3.maven-dependency-plugin (from 3.1.1 to 3.3.0)
https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.1.1...maven-dependency-plugin-3.3.0
https://github.com/apache/maven-dependency-plugin/commit/9646b0ed76a6d00e468c8eb1b6a27d260b09e944
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA and testing with the existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37598:
URL: https://github.com/apache/spark/pull/37598#issuecomment-1222618395
This is reverted via https://github.com/apache/spark/commit/b6192126351ea2ae658e2f0cfd8c57baf3f1d900 in order to recover CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37598:
URL: https://github.com/apache/spark/pull/37598#issuecomment-1222685951
Ya, it was a trick situation~ There exists some investigation result on the reverting PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #37598:
URL: https://github.com/apache/spark/pull/37598#discussion_r952286911
##########
pom.xml:
##########
@@ -2932,7 +2932,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M5</version>
+ <version>3.0.0-M7</version>
Review Comment:
@panbingkun There is a behavioral difference between `3.0.0-M5` and `3.0.0-M7`:
`mvn clean install -pl core -Dtest=none` pass with 3.0.0-M5`, but failed with `3.0.0-M7` as follows:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project spark-core_2.12: No tests matching pattern "none" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
```
seems that configuration `<failIfNoSpecifiedTests>false</failIfNoSpecifiedTests>` needs to be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #37598:
URL: https://github.com/apache/spark/pull/37598#discussion_r953215392
##########
pom.xml:
##########
@@ -2932,7 +2932,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M5</version>
+ <version>3.0.0-M7</version>
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37598:
URL: https://github.com/apache/spark/pull/37598#issuecomment-1222648160
Ah shoot, it failed? OK, weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37598:
URL: https://github.com/apache/spark/pull/37598#issuecomment-1221544024
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #37598:
URL: https://github.com/apache/spark/pull/37598#issuecomment-1223384796
I will investigate the root cause for the failure carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #37598: [SPARK-40165][BUILD] Update test plugins to latest versions
URL: https://github.com/apache/spark/pull/37598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org