You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 19:29:55 UTC
[GitHub] [flink] jianyun8023 opened a new pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
jianyun8023 opened a new pull request #14622:
URL: https://github.com/apache/flink/pull/14622
## What is the purpose of the change
Add the `SourceFunction` implementation of Pulsar to the connector.
## Brief change log
- Add Pulsar SourceFunction implementation
- Supports exactly-one
- Support dynamic discovery of Topic
- Implementation is similar to kafka
## Verifying this change
This change added tests and can be verified as follows:
- Adding basic tests for Source (start, stop, snapshot, checkpoint)
- Pulsar service based on testcontainers
- Unit tests for Pulsar authentication functionality
- Topic dynamic discovery tests
- Pulsar client cache tests
- Watermark function testing
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / **don't know**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-803429679
> @jianyun8023 Sorry I have probably missed the new PRs and can't find them through PR search, could you please link them to me (or add me as a reviewer?).
@AHeise Sorry it took so long to push up the Pulsar implementation based on the `Source` interface. I'm sorry for making you wait so long.
new Pulsar Source: #15304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758893663
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943",
"triggerID" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"triggerType" : "PUSH"
}, {
"hash" : "67d6759cb202d209085675626019768345b716d1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67d6759cb202d209085675626019768345b716d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10dbc3e59fb47de1cb88dc65b40fb4c208e832ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943)
* 67d6759cb202d209085675626019768345b716d1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-772405837
If you only need the new version of the source implementation, I can just submit the new version of the implementation and make the Table based on the new Source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-771496688
Sorry for coming back so late to this PR. Code-wise, it looks mostly fine. I would add a complete code review later.
However, I'd like to clarify first, why we want to have the old implementation in Flink master at all. From my perspective, this is instant legacy. So there needs to be a strong reason to have it compared to merge only the new interfaces.
Possible reasons could include features that cannot be supported with the new PulsarSource. In general, when would a user choose the old implementation over the new implementation given that the new source interface is quite stable in Flink 1.13?
I'm duplicating the reply to the Sink PR as the answer may be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-772402578
> Sorry for coming back so late to this PR. Code-wise, it looks mostly fine. I would add a complete code review later.
>
> However, I'd like to clarify first, why we want to have the old implementation in Flink master at all. From my perspective, this is instant legacy. So there needs to be a strong reason to have it compared to merge only the new interfaces.
>
> Possible reasons could include features that cannot be supported with the new PulsarSource. In general, when would a user choose the old implementation over the new implementation given that the new source interface is quite stable in Flink 1.13?
>
> I'm duplicating the reply to the Sink PR as the answer may be different.
Because the older version of Source has been verified in production and is stable for users to use. The implementation in the new version has yet to be verified.
This is the reason why I want to keep the old version of Source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-775772620
We discussed it and we started by merging the new Source, which allows Flink to not carry the old baggage, the old version is supported and we maintain it in the streamnative/pulsar-flink repository. I'm submitting the new Source implementation today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-773234617
> Because the older version of Source has been verified in production and is stable for users to use. The implementation in the new version has yet to be verified.
> This is the reason why I want to keep the old version of Source.
That's certainly a good argument, but why wouldn't the users simply take the streamnative version if they want to have the stable version?
I'm mostly concerned that if we reach a stable version in the process of bugfixing Flink 1.13, we will add (for all practical purposes) dead code in this PR. Even worse, it may confuse users and they may accidentally choose the old version instead of the new version. Then, the user may experience all the downsides of the old source architecture without even realizing it (there are a few implications regarding checkpointing). To solve it, I guess we would mark the `PulsarSourceFunction` as deprecated, which would mean that we would add code now for 1.13.0 and deprecate it in 1.13.X or latest in 1.14.0. So we are adding code now where we immediately need to think about how to get rid of.
I think the best argument for merging the PR is that the user may actually use the stable `PulsarSourceFunction` in 1.13.0 and then switch to the new `PulsarSource` in 1.13.X without changing dependencies. Another important consideration is if the user can use the old function for use cases where the new `PulsarSource` does not suffice (yet).
Another option is that we prepare this PR (1-2 review cycles) and leave it unmerged until we know that the new `PulsarSource` misses critical feature for 1.13 and merge it then. Until then, I'd prefer to bet on a good first `PulsarSource` (I have no doubts that you will make a good job in porting it) and solve any actual issues with fast bugfix releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-775908504
Okay sounds good. Then let's close this PR for the time being. If we still see a need for it after having the new source in, we can still reopen.
And please add me as a reviewer for the new PRs, so I can pick them up more quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758886440
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 10dbc3e59fb47de1cb88dc65b40fb4c208e832ef (Tue Jan 12 19:33:15 UTC 2021)
**Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20727).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758893663
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943",
"triggerID" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10dbc3e59fb47de1cb88dc65b40fb4c208e832ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] jianyun8023 commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
jianyun8023 commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-803429679
> @jianyun8023 Sorry I have probably missed the new PRs and can't find them through PR search, could you please link them to me (or add me as a reviewer?).
@AHeise Sorry it took so long to push up the Pulsar implementation based on the `Source` interface. I'm sorry for making you wait so long.
new Pulsar Source: #15304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758893663
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943",
"triggerID" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"triggerType" : "PUSH"
}, {
"hash" : "67d6759cb202d209085675626019768345b716d1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12071",
"triggerID" : "67d6759cb202d209085675626019768345b716d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10dbc3e59fb47de1cb88dc65b40fb4c208e832ef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943)
* 67d6759cb202d209085675626019768345b716d1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12071)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-775908504
Okay sounds good. Then let's close this PR for the time being. If we still see a need for it after having the new source in, we can still reopen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758893663
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943",
"triggerID" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"triggerType" : "PUSH"
}, {
"hash" : "67d6759cb202d209085675626019768345b716d1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12071",
"triggerID" : "67d6759cb202d209085675626019768345b716d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67d6759cb202d209085675626019768345b716d1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12071)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758893663
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10dbc3e59fb47de1cb88dc65b40fb4c208e832ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-800151298
@jianyun8023 Sorry I have probably missed the new PRs and can't find them through PR search, could you please link them to me (or add me as a reviewer?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-758893663
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943",
"triggerID" : "10dbc3e59fb47de1cb88dc65b40fb4c208e832ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10dbc3e59fb47de1cb88dc65b40fb4c208e832ef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11943)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-771496688
Sorry for coming back so late to this PR. Code-wise, it looks mostly fine. I would add a complete code review later.
However, I'd like to clarify first, why we want to have the old implementation in Flink master at all. From my perspective, this is instant legacy. So there needs to be a strong reason to have it compared to merge only the new interfaces.
Possible reasons could include features that cannot be supported with the new PulsarSource. In general, when would a user choose the old implementation over the new implementation given that the new source interface is quite stable in Flink 1.13?
I'm duplicating the reply to the Sink PR as the answer may be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #14622:
URL: https://github.com/apache/flink/pull/14622#issuecomment-773234617
> Because the older version of Source has been verified in production and is stable for users to use. The implementation in the new version has yet to be verified.
> This is the reason why I want to keep the old version of Source.
That's certainly a good argument, but why wouldn't the users simply take the streamnative version if they want to have the stable version?
I'm mostly concerned that if we reach a stable version in the process of bugfixing Flink 1.13, we will add (for all practical purposes) dead code in this PR. Even worse, it may confuse users and they may accidentally choose the old version instead of the new version. Then, the user may experience all the downsides of the old source architecture without even realizing it (there are a few implications regarding checkpointing). To solve it, I guess we would mark the `PulsarSourceFunction` as deprecated, which would mean that we would add code now for 1.13.0 and deprecate it in 1.13.X or latest in 1.14.0. So we are adding code now where we immediately need to think about how to get rid of.
I think the best argument for merging the PR is that the user may actually use the stable `PulsarSourceFunction` in 1.13.0 and then switch to the new `PulsarSource` in 1.13.X without changing dependencies. Another important consideration is if the user can use the old function for use cases where the new `PulsarSource` does not suffice (yet).
Another option is that we prepare this PR (1-2 review cycles) and leave it unmerged until we know that the new `PulsarSource` misses critical feature for 1.13 and merge it then. Until then, I'd prefer to bet on a good first `PulsarSource` (I have no doubts that you will make a good job in porting it) and solve any actual issues with fast bugfix releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise closed pull request #14622: [FLINK-20727][connector] pulsar SourceFunction
Posted by GitBox <gi...@apache.org>.
AHeise closed pull request #14622:
URL: https://github.com/apache/flink/pull/14622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org