You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/02 22:52:32 UTC

[GitHub] eolivelli commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception

eolivelli commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception
URL: https://github.com/apache/bookkeeper/pull/1110#discussion_r165780705
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -1014,9 +1032,7 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E
         }
 
         if (cause instanceof IOException) {
-            // these are thrown when a bookie fails, logging them just pollutes
 
 Review comment:
   Any strong reason for dropping the comment and adding this log?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services