You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/07/08 16:58:54 UTC
[PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]
Zakelly opened a new pull request, #25052:
URL: https://github.com/apache/flink/pull/25052
## What is the purpose of the change
The `OperatorSubtaskState` only make keyed state register with `SharedStateRegistry`. However, the file-merging directories's handle are wrapped in `FileMergingOperatorStreamStateHandle}` which is an `OperatorStreamStateHandle`. That means the `#registerSharedStates` is never called, so the registry(JM) will never know and delete the directories.
## Brief change log
- In `OperatorSubtaskState`, we register `FileMergingOperatorStreamStateHandle`.
## Verifying this change
Modified tests in `SnapshotFileMergingCompatibilityITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly merged PR #25052:
URL: https://github.com/apache/flink/pull/25052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25052:
URL: https://github.com/apache/flink/pull/25052#issuecomment-2214715238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cadb2364f238bf047e938b742079f7f56a2b10ea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cadb2364f238bf047e938b742079f7f56a2b10ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cadb2364f238bf047e938b742079f7f56a2b10ea UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org