You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/12 10:16:52 UTC
[GitHub] [pulsar] nodece opened a new pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
nodece opened a new pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190
Signed-off-by: Zixuan Liu <no...@gmail.com>
### Motivation
The `brokerClientAuthenticationEnabled` is boxed type in `WebConfig.java` for solve broker and functions-worker authentication compatibility, so `brokerClientAuthenticationEnabled` should not be in `conf/functions-worker.yml`.
### Modifications
- commented out `brokerClientAuthenticationEnabled` in `conf/functions-worker.yml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-759983505
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-758757954
@nodece Thank you for your fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-760157404
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-760189783
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-758655220
@zymap I made a tests for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-759224905
@sijie @zymap thanks for your review! license header has been fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9190: [Functions-worker] Fix broker and functions-worker authentication compatibility
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9190:
URL: https://github.com/apache/pulsar/pull/9190#issuecomment-759179486
@nodece Can you fix the license header issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org