You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/20 18:23:42 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #19010: [improve][io] Upgrade Kafka client, connect runtime to 2.8.2 and Confluent version to 6.2.8

lhotari commented on code in PR #19010:
URL: https://github.com/apache/pulsar/pull/19010#discussion_r1053623398


##########
pom.xml:
##########
@@ -187,9 +187,9 @@ flexible messaging model and an intuitive client API.</description>
     <guava.version>31.0.1-jre</guava.version>
     <jcip.version>1.0</jcip.version>
     <prometheus-jmx.version>0.16.1</prometheus-jmx.version>
-    <confluent.version>7.0.1</confluent.version>
-    <kafka.confluent.schemaregistryclient.version>5.3.0</kafka.confluent.schemaregistryclient.version>
-    <kafka.confluent.avroserializer.version>5.3.0</kafka.confluent.avroserializer.version>
+    <confluent.version>6.2.8</confluent.version>
+    <kafka.confluent.schemaregistryclient.version>${confluent.version}</kafka.confluent.schemaregistryclient.version>
+    <kafka.confluent.avroserializer.version>${confluent.version}</kafka.confluent.avroserializer.version>

Review Comment:
   I guess so. I'll wait for options from other reviewer before making the change. @dlg99 What do you recommend?



##########
pom.xml:
##########
@@ -187,9 +187,9 @@ flexible messaging model and an intuitive client API.</description>
     <guava.version>31.0.1-jre</guava.version>
     <jcip.version>1.0</jcip.version>
     <prometheus-jmx.version>0.16.1</prometheus-jmx.version>
-    <confluent.version>7.0.1</confluent.version>
-    <kafka.confluent.schemaregistryclient.version>5.3.0</kafka.confluent.schemaregistryclient.version>
-    <kafka.confluent.avroserializer.version>5.3.0</kafka.confluent.avroserializer.version>
+    <confluent.version>6.2.8</confluent.version>
+    <kafka.confluent.schemaregistryclient.version>${confluent.version}</kafka.confluent.schemaregistryclient.version>
+    <kafka.confluent.avroserializer.version>${confluent.version}</kafka.confluent.avroserializer.version>

Review Comment:
   I guess so. I'll wait for options from other reviewers before making the change. @dlg99 What do you recommend?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org