You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/10/03 18:05:17 UTC

[GitHub] [knox] lmccay commented on a change in pull request #153: KNOX-2020 - AWS federation support added to hadoop-jwt cookie

lmccay commented on a change in pull request #153: KNOX-2020 - AWS federation support added to hadoop-jwt cookie
URL: https://github.com/apache/knox/pull/153#discussion_r331177182
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -209,15 +211,19 @@
         <libpam4j.version>1.11</libpam4j.version>
         <log4j.version>1.2.17</log4j.version>
         <log4j2.version>2.12.1</log4j2.version>
+        <lombok-version>1.18.4</lombok-version>
+        <log4j2.version>2.12.1</log4j2.version>
 
 Review comment:
   Why are we pulling in lombok here? This isn't used across the other features within Knox and I don't see any reason to add it here making this code different from the rest.
   
   We do need to see a contributed consumer of this within the PR that makes it usable out of the box for the Knox community.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services