[GitHub] [superset] betodealmeida commented on a change in pull request #16327: feat: Add new dev commands to Makefile

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #16327:
URL: https://github.com/apache/superset/pull/16327#discussion_r692288987



##########
File path: Makefile
##########
@@ -81,3 +81,9 @@ py-lint: pre-commit
 
 js-format:
 	cd superset-frontend; npm run prettier

Review comment:
       Same here.

##########
File path: Makefile
##########
@@ -58,7 +58,7 @@ update-py:
 
 update-js:
 	# Install js packages
-	cd superset-frontend; npm install
+	cd superset-frontend; npm ci

Review comment:
       A suggestion; instead of using `cd` do this:
   
   ```suggestion
   	pushd superset-frontend; npm ci; popd
   ```
   
   This will bring back the user to the directory they were when they ran the command.

##########
File path: Makefile
##########
@@ -81,3 +81,9 @@ py-lint: pre-commit
 
 js-format:
 	cd superset-frontend; npm run prettier
+
+flask-app:
+	flask run -p 8088 --with-threads --reload --debugger
+
+node-app:
+	cd superset-frontend; npm run dev-server

Review comment:
       And here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org