You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "gongyisheng (via GitHub)" <gi...@apache.org> on 2023/08/26 07:35:59 UTC

[GitHub] [incubator-opendal] gongyisheng opened a new pull request, #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

gongyisheng opened a new pull request, #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942

   implement https://github.com/apache/incubator-opendal/issues/2940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942#issuecomment-1694220287

   Thanks for the PR. But this PR doesn't work as expected. Did you test it locally via cargo doc?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942#issuecomment-1694222700

   Ok, let me take a look later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] gongyisheng commented on pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "gongyisheng (via GitHub)" <gi...@apache.org>.
gongyisheng commented on PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942#issuecomment-1694214335

   Hi @oowl, let me know if you see there's missing broken links.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] gongyisheng commented on pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "gongyisheng (via GitHub)" <gi...@apache.org>.
gongyisheng commented on PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942#issuecomment-1694222018

   @Xuanwo Yes, I tested it locally, it behaves different from the one in online env. But I saw https://github.com/gongyisheng/incubator-opendal/blob/fix_doc_link/core/src/raw/accessor.rs#L40 use the same syntax for doc so I think it'll work as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942#issuecomment-1694234123

   > I think we can add a gh-pages perview for document update in the future.
   
   We are deploying to ASF Site which is a bit more complex than gh-pages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] oowl merged pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl merged PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] dqhl76 commented on pull request #2942: fix(doc): use crate::docs::rfc to replace relative path in doc

Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2942:
URL: https://github.com/apache/incubator-opendal/pull/2942#issuecomment-1694233286

   I think we can add a gh-pages perview for document update in the future. I found GitHub added a parameter for enable that but it still not release to public. https://github.com/actions/deploy-pages/tree/b580d214b4e13b2a70d0e04376a86ed862ebb558#inputs-


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org