[GitHub] [royale-asjs] carlosrovira commented on pull request #922: Fixed Jewel ComboBox freeze with SearchFilter

[GitBox <gi...@apache.org>]

carlosrovira commented on pull request #922:
URL: https://github.com/apache/royale-asjs/pull/922#issuecomment-712666773


   Hi Hugo,
   
   I could try and that fix the problem in part, checking the code don't understand why it was not working before since seems to be the same. Maybe the remove listener was affecting...
   
   while testing I see that pushing key down is not working too with search filter, that is something we should take a look but I think could be left for other ticket.
   
   About the helper function: I think is important to not mix different things in the same PR. So that should be discussed in other way.
   
   So, since you're a committer, you don't need me to merge, you can do it yourself. I think you can:
   
   - Close this PR
   - Merge the Jewel ComboBox fix
   - Open a thread in mailing list about the helper function in bead, since @Harbs and others could have something to say. That's because we try to keep core as PAYG as possible so that kind of changes need to be advised.
   
   Thanks!
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org