You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 22:18:46 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15393: Add Connection Documentation for Popular Providers

kaxil commented on a change in pull request #15393:
URL: https://github.com/apache/airflow/pull/15393#discussion_r620688713



##########
File path: airflow/providers/mongo/hooks/mongo.py
##########
@@ -40,11 +40,12 @@ class MongoHook(BaseHook):
     ex.
         {"srv": true, "replicaSet": "test", "ssl": true, "connectTimeoutMS": 30000}
 
-    :param conn_id: This is the Airflow connection to use for Mongo credentials.
-    :type conn_id: str
+    :param mongo_conn_id: The :ref:`Mongo connection id <howto/connection:mongo>` to use
+        when connecting to MongoDB.
+    :type mongo: str
     """
 
-    conn_name_attr = 'conn_id'
+    conn_name_attr = 'mongo_conn_id'

Review comment:
       don't think this will work as the kwarg on L53 needs changing to `mongo_conn_id` from `conn_id`.
   
   Lets remove this change from this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org