[GitHub] [lucene-solr] romseygeek commented on issue #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

[GitBox <gi...@apache.org>]

romseygeek commented on issue #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching
URL: https://github.com/apache/lucene-solr/pull/1037#issuecomment-558080788
 
 
   I've gone back and forth on the best implementation here, particularly in terms of what we should actually be passing back to `consumeTermsMatching`.  I ended up going with a `BytesRunAutomaton` as it most closely goes with `consumeTerms` which deals with byte-oriented terms.  However, as highlighting is currently the only consumer of this API and it needs char-oriented matchers I can see the arguments the other way.
   
   There's also a nocommit around what we should pass back in the case of a `AUTOMATON_TYPE.ALL` matcher - at the moment I'm just calling `visitLeaf` but we perhaps need another method, something like `consumeAnyTerm`?
   
   I we do go with something like this, we'll probably want to re-work the unified highlighter to merge the visitor that extracts terms and the one that extracts automata, as there is some work that gets done twice currently (particularly for FuzzyQuery)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org