[GitHub] [incubator-druid] shuqi7 commented on a change in pull request #7242: Add compaction dialog in druid console which allows users to add/edit data source compaction configuration

[GitBox <gi...@apache.org>]

shuqi7 commented on a change in pull request #7242: Add compaction dialog in druid console which allows users to add/edit data source compaction configuration
URL: https://github.com/apache/incubator-druid/pull/7242#discussion_r266154516
 
 

 ##########
 File path: web-console/src/components/filler.tsx
 ##########
 @@ -257,3 +259,63 @@ export class TagInput extends React.Component<TagInputProps, { stringValue: stri
     />;
   }
 }
+
+interface JSONInputProps extends React.Props<any>{
+  onChange: (newValue: string) => void;
+  value: JSON;
+  updateErrors: ((newValue: string) => void)
+}
+
+interface JSONInputState{
+  stringValue: string;
+}
+
+export class JSONInput extends React.Component<JSONInputProps, JSONInputState> {
+  constructor(props: JSONInputProps) {
+    super(props);
+    this.state = {
+      stringValue: ""
+    }
+  }
+
+  componentDidMount(): void {
+    const { value } = this.props;
+    const stringValue = parseJSONToString(value);
+    this.setState({
+      stringValue: stringValue
+    })
+  }
 
 Review comment:
   Would it be a better idea to use `componentDidUpdate` or `componentWillReceiveProps` (though deprecated) than `getDerivedStateFromProps`? Since we are mainly checking if the previous and current props are matched when props are changed outside the autoform?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org