You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2010/04/22 14:03:40 UTC

svn commit: r936802 - /subversion/trunk/subversion/tests/svn_test_main.c

Author: stsp
Date: Thu Apr 22 12:03:40 2010
New Revision: 936802

URL: http://svn.apache.org/viewvc?rev=936802&view=rev
Log:
* subversion/tests/svn_test_main.c
  (main): Override the default malfunction handler to avoid abort()
   in the C tests. If SVN_ERR_ASSERT() fails in a C test, we should
   treat this as XFAIL rather than dumping core.

Modified:
    subversion/trunk/subversion/tests/svn_test_main.c

Modified: subversion/trunk/subversion/tests/svn_test_main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=936802&r1=936801&r2=936802&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/svn_test_main.c (original)
+++ subversion/trunk/subversion/tests/svn_test_main.c Thu Apr 22 12:03:40 2010
@@ -383,6 +383,10 @@ main(int argc, const char *argv[])
   cleanup_pool = svn_pool_create(pool);
   test_pool = svn_pool_create(pool);
 
+  /* Make sure we don't abort() on SVN_ERR_ASSERT() failures,
+   * to allow for clean XFAIL tests. */
+  svn_error_set_malfunction_handler(svn_error_raise_on_malfunction);
+
   if (argc >= 2)  /* notice command-line arguments */
     {
       if (! strcmp(argv[1], "list") || list_mode)



Re: svn commit: r936802 - /subversion/trunk/subversion/tests/svn_test_main.c

Posted by Greg Stein <gs...@gmail.com>.
On Thu, Apr 22, 2010 at 08:03,  <st...@apache.org> wrote:
> Author: stsp
> Date: Thu Apr 22 12:03:40 2010
> New Revision: 936802
>
> URL: http://svn.apache.org/viewvc?rev=936802&view=rev
> Log:
> * subversion/tests/svn_test_main.c
>  (main): Override the default malfunction handler to avoid abort()
>   in the C tests. If SVN_ERR_ASSERT() fails in a C test, we should
>   treat this as XFAIL rather than dumping core.

You're not supposed to use SVN_ERR_ASSERT for test conditions. Those
should continue to validate assumptions scattered throughout our code.

For *testing*, you should be using SVN_TEST_ASSERT() and
SVN_TEST_STRING_ASSERT(), found in tests/svn_test.h.

>...

Cheers,
-g