You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/13 22:09:28 UTC
[GitHub] [arrow-adbc] jmao-denver opened a new pull request, #349: feat(c/driver/postgresql): Add varchar type support
jmao-denver opened a new pull request, #349:
URL: https://github.com/apache/arrow-adbc/pull/349
'varchar' and 'text' are really the same type so just need to add it to the supported list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383146209
#351fixes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] jmao-denver commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
jmao-denver commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383042767
It seems that CI failed in the same place. I know almost nothing of Ruby but I don't see how the change could break the Ruby driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1382918354
Thanks!
The Ruby CI is having some trouble - I'll look at that soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1384606369
#352 adds the unit tests, including for the VARCHAR type here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383169274
I've merged Kou's fix. Do you mind rebasing one more time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] jmao-denver commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
jmao-denver commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383185778
@lidavidm just did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383012982
Odd, it passes when I try to reproduce it on a branch. Do you mind rebasing this with main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] jmao-denver commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
jmao-denver commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383265918
Thanks, David. I did test it in Python 3.9 on MacOS 13.1 before I submitted the PR. If you'd like, please tag me once you have finalized on the testing wiring. I'd be happy to add an unit test for the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] jmao-denver commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
jmao-denver commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383034743
just did, hopefully no CI issue anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on pull request #349: feat(c/driver/postgresql): Add varchar type support
Posted by GitBox <gi...@apache.org>.
kou commented on PR #349:
URL: https://github.com/apache/arrow-adbc/pull/349#issuecomment-1383063659
Ah, it will be related to https://github.com/apache/arrow-adbc/pull/345 .
I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org