You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Murali Reddy <mu...@gmail.com> on 2013/03/21 13:18:35 UTC

Review Request: CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10061/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

Patch for 4.1 blocker "CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException."


This addresses bugs -, CLOUDSTACK-1368:, Not, Shared, able, because, delete, java.lang.NullPointerException., network, network, of, and to.


Diffs
-----

  api/src/com/cloud/network/Network.java 2bf7b7f 

Diff: https://reviews.apache.org/r/10061/diff/


Testing
-------

Tested life cycle of both isolated and shared networks


Thanks,

Murali Reddy


Re: Review Request: CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10061/#review18245
-----------------------------------------------------------


Commit 1c845d42b703bf4608873fd777b9bfef5d3feee5 in branch refs/heads/master from Murali Reddy <mu...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1c845d4 ]

CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException

Missed network destroy state transistion while 'events framework' merge.
Before merge, network states were explicitly set. It was changed to go
through state machine. This fix, introduces  missing state transistions.

Tested life cycle of both isolated and shared network

Signed-off-by: Murali Reddy <mu...@citrix.com>


- ASF Subversion and Git Services


On March 21, 2013, 3:41 p.m., Murali Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10061/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 3:41 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Patch for 4.1 blocker "CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException."
> 
> 
> This addresses bug CLOUDSTACK-1368.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java 2bf7b7f 
> 
> Diff: https://reviews.apache.org/r/10061/diff/
> 
> 
> Testing
> -------
> 
> Tested life cycle of both isolated and shared networks
> 
> 
> Thanks,
> 
> Murali Reddy
> 
>


Re: Review Request: CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException.

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10061/#review18209
-----------------------------------------------------------

Ship it!


Committed to 4.1:

commit 0e33ba8d353aa0ae7bac5260daa0d710306372bb
Author: Murali Reddy <mu...@citrix.com>
Date:   Thu Mar 21 17:38:33 2013 +0530

    CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException
    
    Missed network destroy state transistion while 'events framework' merge.
    Before merge, network states were explicitly set. It was changed to go
    through state machine. This fix, introduces  missing state transistions.
    
    Tested life cycle of both isolated and shared network
    
    Signed-off-by: Murali Reddy <mu...@citrix.com>

- Chip Childers


On March 21, 2013, 3:41 p.m., Murali Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10061/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 3:41 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Patch for 4.1 blocker "CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException."
> 
> 
> This addresses bug CLOUDSTACK-1368.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java 2bf7b7f 
> 
> Diff: https://reviews.apache.org/r/10061/diff/
> 
> 
> Testing
> -------
> 
> Tested life cycle of both isolated and shared networks
> 
> 
> Thanks,
> 
> Murali Reddy
> 
>


Re: Review Request: CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException.

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10061/
-----------------------------------------------------------

(Updated March 21, 2013, 3:41 p.m.)


Review request for cloudstack and Chip Childers.


Description
-------

Patch for 4.1 blocker "CLOUDSTACK-1368: Shared network - Not able to delete network because of java.lang.NullPointerException."


This addresses bug CLOUDSTACK-1368.


Diffs
-----

  api/src/com/cloud/network/Network.java 2bf7b7f 

Diff: https://reviews.apache.org/r/10061/diff/


Testing
-------

Tested life cycle of both isolated and shared networks


Thanks,

Murali Reddy