[GitHub] [kafka] jolshan commented on a diff in pull request #12543: KAFKA-10149: Allow auto preferred leader election for partitions are not being reassigned

[GitBox <gi...@apache.org>]

jolshan commented on code in PR #12543:
URL: https://github.com/apache/kafka/pull/12543#discussion_r950574990


##########
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##########
@@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {
       "failed to get expected partition state upon broker startup")
   }
 
+  @Test
+  def testAutoPreferredReplicaLeaderElectionWithReassigningPartitions(): Unit = {

Review Comment:
   I think it would still work fine, but did we consider a situation where the preferred leader election occurs right before or at the same time as the reassignment completes? 
   For example, we have a reassignment going, a broker is restarted, and we may or may not have preferred leader election before it completes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org