You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "phet (via GitHub)" <gi...@apache.org> on 2023/04/12 00:10:51 UTC
[GitHub] [gobblin] phet opened a new pull request, #3675: [GOBBLIN-1814] Add `MRJobLauncher` configurability for any failing mapper to be fatal to the MR job
phet opened a new pull request, #3675:
URL: https://github.com/apache/gobblin/pull/3675
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1814
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Currently, the value of the MR config `mapreduce.map.failures.maxpercent` is hardcoded to 100%, which means even though mappers may fail, the job would still continue. a customer seeks the ability to set `maxpercent` to 0, so if any mapper fails, the overall job too would fail.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
none, as configuration is passed-through directly to MR, with interpretation there
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3675: [GOBBLIN-1814] Add `MRJobLauncher` configurability for any failing mapper to be fatal to the MR job
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3675:
URL: https://github.com/apache/gobblin/pull/3675#issuecomment-1504349222
## [Codecov](https://codecov.io/gh/apache/gobblin/pull/3675?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3675](https://codecov.io/gh/apache/gobblin/pull/3675?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f80d048) into [master](https://codecov.io/gh/apache/gobblin/commit/0d69363abc776812a4f0352860a4125c7f28a508?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d69363) will **increase** coverage by `0.01%`.
> The diff coverage is `25.00%`.
```diff
@@ Coverage Diff @@
## master #3675 +/- ##
============================================
+ Coverage 46.84% 46.86% +0.01%
- Complexity 10751 10757 +6
============================================
Files 2139 2140 +1
Lines 84032 84056 +24
Branches 9335 9339 +4
============================================
+ Hits 39366 39391 +25
+ Misses 41082 41080 -2
- Partials 3584 3585 +1
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | |
| [...pache/gobblin/runtime/mapreduce/MRJobLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL01SSm9iTGF1bmNoZXIuamF2YQ==) | `53.17% <25.00%> (-0.40%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/gobblin/pull/3675/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3675: [GOBBLIN-1814] Add `MRJobLauncher` configurability for any failing mapper to be fatal to the MR job
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3675:
URL: https://github.com/apache/gobblin/pull/3675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org