[jira] [Commented] (TOMEE-2197) openejb.xml does not work

["Gurkan Erdogdu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TOMEE-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521914#comment-16521914 ] 

Gurkan Erdogdu commented on TOMEE-2197:
---------------------------------------

Here is the location in SaxOpenEjb.java which sets file of Deployments object: (as MArk said, if there is a file element in addition to jar, jar is overrided). What do you think to update this code?
{code:java}
       public void startElement(final String uri, final String localName, final String qName, final Attributes attributes) throws SAXException {
            deployments.setDir(attributes.getValue("dir"));
            deployments.setFile(attributes.getValue("jar"));
            deployments.setFile(attributes.getValue("file"));
            deployments.setAutoDeploy("true".equals(attributes.getValue("autoDeploy")));
            checkAttributes(attributes, "dir", "jar", "file", "autoDeploy");
        }{code}

> openejb.xml <Deployments jar="..."/> does not work
> --------------------------------------------------
>
>                 Key: TOMEE-2197
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2197
>             Project: TomEE
>          Issue Type: Bug
>          Components: TomEE Core Server
>    Affects Versions: 7.0.4
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Minor
>             Fix For: 8.0.0, 7.0.5
>
>
> When declaring a deployment in openejb.xml or tomee.xml we scan <Deployments> sections.
> This contains a file= and a jar= attribute. 
> The jar= does not work because it later gets overridden by the (often empty) file attribute.
> WORKAROUND: just use the file= attribute and be done
> Should be fixed nonetheless. And should issue a warning if both attributes are used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)