[jira] [Commented] (TS-4870) Storage can be marked offline multiple times which breaks related metrics

["Gancho Tenev (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494410#comment-15494410 ] 

Gancho Tenev commented on TS-4870:
----------------------------------

Repeat the test with the patch applied:

{code}
# Initial cache size (when using both disks).
$ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
proxy.node.cache.bytes_total 268025856

# Take 1st disk offline. Cache size changes as expected.
$ sudo ./bin/traffic_ctl storage offline /dev/sdb
$ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
proxy.node.cache.bytes_total 134012928

# Take same disk offline again. Now good!
$ sudo ./bin/traffic_ctl storage offline /dev/sdb
$ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
proxy.node.cache.bytes_total 134012928

# Take same disk offline again. Good again.
$ sudo ./bin/traffic_ctl storage offline /dev/sdb
$ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
proxy.node.cache.bytes_total 134012928
{code}

> Storage can be marked offline multiple times which breaks related metrics
> -------------------------------------------------------------------------
>
>                 Key: TS-4870
>                 URL: https://issues.apache.org/jira/browse/TS-4870
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache, Metrics
>            Reporter: Gancho Tenev
>            Assignee: Gancho Tenev
>             Fix For: 7.0.0
>
>
> Let us say traffic server is running with 2 disks
> {code}
> $ cat etc/trafficserver/storage.config
> /dev/sdb
> /dev/sdc
> $ sudo fdisk -l|grep 'Disk /dev/sd[b|c]'
> Disk /dev/sdb: 134 MB, 134217728 bytes
> Disk /dev/sdc: 134 MB, 134217728 bytes
> {code}
> Let us see what happens when we mark the same disk 3 times in a raw ({{/dev/sdb}}) and check the {{proxy.node.cache.bytes_total}}.
> {code}
> # Initial cache size (when using both disks).
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 268025856
> # Take 1st disk offline. Cache size changes as expected.
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 134012928
> # Take same disk offline again. Not good!
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 0
> # Take same disk offline again. Negative value.
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total -134012928
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)